Add new commands, option to disable talent templating and refactor code.

[arenacraftwow]

Like the commit message says. I've backported the features I had on my skirmish arena server. The commands I've added were working as intended there and were used heavily. But I've also cleaned up my code so some issues might have slipped in (altho I've tried to continuously test out all the differences I've made to my original version).

I'm gonna use this version on my server so if I find anything I will let u know.

Stuff added/changed

• [NEW] copy command - a GM can clone a player, he can then use that player to create a new template
• [NEW] save command - a GM can update a template based on his current gear.
• [FIX] Fixed a crash if someone used the (hidden) gossip option 32
• [FIX] Shouldn't generate as many Player (xx) tries to learn already active spell warnings
• [CODE] A lot of code cleanups and manual deduplications, also run my clag formatter thru the code so some changes are caused by it. Might include have slight performance improvements.
• Slightly mitigated Talent spells are taught to the player, not granted as talents #11 by adding a compile time constant to remove this feature. On my server I just don't use talent templating, just running with the mod-learn-highest-talent. By default talents will be left in tact as they are currently but this gives the ability to remove that feature in a build if needed.

[BarbzYHOOL]

can you add the corresponding commands in sql command table in a sql file?

I also suggest to change ".templatenpc" into the simpler ".template" as there is nothing NPC related in that command

[arenacraftwow]

@BarbzYHOOL Will do.

[arenacraftwow]

@BarbzYHOOL Done

[BarbzYHOOL]

"Slightly mitigated #11 by adding a compile time constant to remove this feature. On my server I just don't use talent templating, just running with the mod-learn-highest-talent. By default talents will be left in tact as they are currently but this gives the ability to remove that feature in a build if needed."

I don't understand. What is the solution actually? is there a solution?

[BarbzYHOOL]

well after my suggestions, i guess we can merge, i quickly checked the code but i'm not the most qualified for that but nobody is working on the module at the moment anyway

[arenacraftwow]

"Slightly mitigated #11 by adding a compile time constant to remove this feature. On my server I just don't use talent templating, just running with the mod-learn-highest-talent. By default talents will be left in tact as they are currently but this gives the ability to remove that feature in a build if needed."

I don't understand. What is the solution actually? is there a solution?

It means that you can easly disable talent/glyph templating. So that the NPC only does Gear related stuff, which is enough for my use case.

[BarbzYHOOL]

well looks good, you tried the new command names tho? just in case a typo or smthg

[arenacraftwow]

seems to still work.

[Helias]

adding a DELETE before all this INSERT should be better I think

[BarbzYHOOL]

wait I just realize all these are for the WORLD db not the characters DB

omfg i should have merged my PR before

@arenacraftwow do you mind if I merge this old PR before this one? https://github.com/azerothcore/mod-npc-talent-template/pull/16/files it might create small conflicts though

[arenacraftwow]

@BarbzYHOOL I dunno, can't you just merge this and then adjust your PR. Then you could do all the DB changes you would like.

[P-Kito]

Attach the * sign to the type instead of the name

[arenacraftwow]

@P-Kito Well looks like I forgot to reformat the header file.

[arenacraftwow]

Please just merge it or leave some serious criticism of the code. It's tiresome having to wake up and re-adjust these minor things, everyday since the past days.

[chamorrorenzo]

Hello there, Im trying this atm, and is amazing, I too wanted to stop using this cause of the talents learned beeing bugged when you use any option then its imposible to remove them from a player

im guessing this is where you change the option
static constexpr bool OMIT_TALENT_AND_GLYPH_TEMPLATING = false;

another question, when I save a template, it adds the new to the DB but the previus one still exist, is there any conflict with that? or its better delete the previus one

thanks

[mindsear]

Sounds complicated

[pangolp]

Can this pull request be closed? From what I see, a lot of time has passed, almost 3 years, since its creation and I don't know if they are going to really take it back.