Add NVMe role #312
Add NVMe role #312
Conversation
|
@assumptionsandg what's the status of this? If it's still relevant can you update the PR description to provide more context please? |
|
This was for the longhorn on baremetal nodes work, but has stalled because the customer ended up not using baremetal nodes directly that needed this fix. |
assumptionsandg
force-pushed
the
add-nvme-role
branch
from
2eeab40 to
b8be5e4
Compare
| lvnames: | ||
| - lvname: primary | ||
| size: 100%FREE | ||
| opts: --type raid0 |
There was a problem hiding this comment.
I am tempted to make sure the raid is configurable here.
|
|
||
| - name: Ensure LVM configuration is applied | ||
| vars: | ||
| manage_lvm: True |
There was a problem hiding this comment.
we should fix the lint issues, of course.
|
|
||
| - name: Ensure disks are mounted | ||
| ansible.posix.mount: | ||
| path: "{{ '/mnt/nvme' + loop.index }}" |
There was a problem hiding this comment.
I think we need to make this just match the disk names here, so /dev/foo is mounted at /mnt/foo... maybe?
| name: linux-volumes-by-tag | ||
|
|
||
| - include_role: | ||
| name: linux-nvme |
There was a problem hiding this comment.
I wonder if we should just call this linux-extra-disks or something more generic?
There was a problem hiding this comment.
I think technically, we should also have underscores in this role names, but I get this is locally consistent.
No description provided.