Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ant convert gradle feasure #260

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

wangqiaoshi
Copy link

convert ant to gradle

@suvodeep-pyne
Copy link

Curious. Why a new PR?

Copy link

@suvodeep-pyne suvodeep-pyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to the nature of the change, this can break a lot of existing code.

@wangqiaoshi
Copy link
Author

i'm sorry to new PR.I found old pr has some information i won't commit.
except azkaban-common.jar,azkaban-web-server.jar,azkaban-exec-server.jar is not in public repository,i find teradata-connector-1.4.2.jar etc also are not in.how are we manager those jar?

@wangqiaoshi
Copy link
Author

i agree with you break existing code.
The idea is project azkaban-plugins should contain only the plugin.Common module hadoopsecuritymanager hadoopsecuritymanager - common, hadoopsecuritymanager - yarn should be placed in azkaban-common.

@wangqiaoshi
Copy link
Author

about breaking existing code,can you talk about yout ideas?

@suvodeep-pyne
Copy link

We cannot commit something that will break existing stuff. You can put all of these old jars in a single directory like rootproject/lib. The switch to gradle should build the same artifacts but probably with minor changes like adding version numbers, etc.

@wangqiaoshi
Copy link
Author

@suvodeep-pyne ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants