Support detect Azure Event Hubs, connect by connection string.#8
Support detect Azure Event Hubs, connect by connection string.#8rujche merged 2 commits intoazure-javaee:feature/sjadfrom rujche:support-detect-event-hubs
Conversation
| name: connectionStringSecretName | ||
| parent: keyVault | ||
| properties: { | ||
| value: 'DefaultEndpointsProtocol=https;AccountName=${storageAccount.name};AccountKey=${storageAccount.listKeys().keys[0].value};EndpointSuffix=${environment().suffixes.storage}' |
There was a problem hiding this comment.
FYI: This is different to Event Hubs and Service Bus.
| {{- if (and .AzureEventHubs .AzureEventHubs.AuthUsingManagedIdentity) }} | ||
| { | ||
| name: 'SPRING_CLOUD_AZURE_EVENTHUBS_CONNECTION_STRING' | ||
| name: 'SPRING_CLOUD_AZURE_EVENTHUBS_CONNECTIONSTRING' |
There was a problem hiding this comment.
FYI: Both SPRING_CLOUD_AZURE_EVENTHUBS_CONNECTION_STRING and SPRING_CLOUD_AZURE_EVENTHUBS_CONNECTION_STRINGSPRING_CLOUD_AZURE_EVENTHUBS_CONNECTIONSTRING can work, but SPRING_CLOUD_AZURE_EVENTHUBS_CONNECTION_STRING is the legacy format.
There was a problem hiding this comment.
Did you mean SPRING_CLOUD_AZURE_EVENTHUBS_CONNECTIONSTRING?
There was a problem hiding this comment.
Yes. you are right. I updated the comment.
| {{- if (and .AzureEventHubs .AzureEventHubs.AuthUsingConnectionString) }} | ||
| { | ||
| name: 'SPRING_CLOUD_AZURE_EVENTHUBS_CONNECTION_STRING' | ||
| name: 'SPRING_CLOUD_AZURE_EVENTHUBS_CONNECTIONSTRING' |
| {{- if (and .AzureStorageAccount .AzureStorageAccount.AuthUsingManagedIdentity) }} | ||
| { | ||
| name: 'SPRING_CLOUD_AZURE_STORAGE_CREDENTIAL_MANAGEDIDENTITYENABLED' | ||
| name: 'SPRING_CLOUD_AZURE_EVENTHUBS_PROCESSOR_CHECKPOINTSTORE_CONNECTIONSTRING' |
There was a problem hiding this comment.
FYI: SPRING_CLOUD_AZURE_EVENTHUBS_PROCESSOR_CHECKPOINTSTORE_CONNECTION_STRING can not work.
Reason:
Convert all - to _ is supported, convert none is also supported. Convert sub set is not supported.
- Convert all:
SPRING_CLOUD_AZURE_EVENTHUBS_PROCESSOR_CHECKPOINT_STORE_CONNECTION_STRING. - Convert none:
SPRING_CLOUD_AZURE_EVENTHUBS_PROCESSOR_CHECKPOINTSTORE_CONNECTIONSTRING. - Convert sub set:
SPRING_CLOUD_AZURE_EVENTHUBS_PROCESSOR_CHECKPOINTSTORE_CONNECTIO_NSTRING.
There was a problem hiding this comment.
I am just curious how they match the CHECKPOINT_STORE here, is it that if it's a camel case, such as aB, it will switch to A_B?
There was a problem hiding this comment.
For aB, it will firstly convert to a-b, then supports both AB and A_B,
Another example: For aBcD it will firstly convert to a-bc-d, then surrprts both ABCD and A_BC_D, but not support others like A_BCD. The suggested way is using ABCD.
Refs:
2 participants
Follow up of #6
Support detect Azure Event Hubs