[AutoPR @azure/arm-subscriptions] (ARMSubscription) fixes Azure/azure-sdk-for-go#18620

sdk/subscription/arm-subscriptions/CHANGELOG.md

@@ -1,15 +1,15 @@
 # Release History
+
+## 5.1.0 (2022-08-25)
+
+**Features**
 
-## 5.0.2 (Unreleased)
-
-### Features Added
-
-### Breaking Changes
-
-### Bugs Fixed
-
-### Other Changes
-
+  - Added Type Alias Provisioning
+  - Interface AcceptOwnershipStatusResponse has a new optional parameter provisioningState
+  - Interface Subscription has a new optional parameter tags
+  - Interface Subscription has a new optional parameter tenantId
+  - Added Enum KnownProvisioning
+
 ## 5.0.1 (2022-05-05)
 
 **Features**

sdk/subscription/arm-subscriptions/_meta.json

@@ -1,8 +1,8 @@
 {
-  "commit": "d600759c3516b61a7c353bc8682bccbab85a6f65",
-  "readme": "specification\\subscription\\resource-manager\\readme.md",
-  "autorest_command": "autorest --version=3.7.3 --typescript --modelerfour.lenient-model-deduplication --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=D:\\work\\azure-sdk-for-js ..\\azure-rest-api-specs\\specification\\subscription\\resource-manager\\readme.md --use=@autorest/[email protected]alpha.19.20220408.1 --generate-sample=true",
+  "commit": "8c5a67d031b48e7e8f9c9c322e8c7ecf689dfbf7",
+  "readme": "specification/subscription/resource-manager/readme.md",
+  "autorest_command": "autorest --version=3.8.4 --typescript --modelerfour.lenient-model-deduplication --azure-arm --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-js ../azure-rest-api-specs/specification/subscription/resource-manager/readme.md --use=@autorest/[email protected]rc.1",
   "repository_url": "https://github.com/Azure/azure-rest-api-specs.git",
-  "release_tool": "@azure-tools/js-sdk-release-tools@2.3.0",
-  "use": "@autorest/[email protected]alpha.19.20220408.1"
-}
+  "release_tool": "@azure-tools/js-sdk-release-tools@2.4.2",
+  "use": "@autorest/[email protected]rc.1"
+}

sdk/subscription/arm-subscriptions/package.json

@@ -3,7 +3,7 @@
   "sdk-type": "mgmt",
   "author": "Microsoft Corporation",
   "description": "A generated SDK for SubscriptionClient.",
-  "version": "5.0.2",
+  "version": "5.1.0",
   "engines": {
     "node": ">=12.0.0"
   },
@@ -40,9 +40,13 @@
     "uglify-js": "^3.4.9",
     "rimraf": "^3.0.0",
     "@azure/identity": "^2.0.1",
-    "@azure-tools/test-recorder": "^1.0.0",
+    "@azure-tools/test-recorder": "^2.0.0",
+    "@azure-tools/test-credential": "^1.0.0",
     "mocha": "^7.1.1",
-    "cross-env": "^7.0.2"
+    "@types/chai": "^4.2.8",
+    "chai": "^4.2.0",
+    "cross-env": "^7.0.2",
+    "@azure/dev-tool": "^1.0.0"
   },
   "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/subscription/arm-subscriptions",
   "repository": {
@@ -93,9 +97,8 @@
     "unit-test:node": "cross-env TEST_MODE=playback npm run integration-test:node",
     "unit-test:browser": "echo skipped",
     "integration-test": "npm run integration-test:node && npm run integration-test:browser",
-    "integration-test:node": "mocha -r esm --require ts-node/register --timeout 1200000 --full-trace test/*.ts --reporter ../../../common/tools/mocha-multi-reporter.js",
-    "integration-test:browser": "echo skipped",
-    "docs": "echo skipped"
+    "integration-test:node": "dev-tool run test:node-ts-input -- --timeout 1200000 'test/*.ts'",
+    "integration-test:browser": "echo skipped"
   },
   "sideEffects": false,
   "//metadata": {
@@ -106,13 +109,5 @@
       }
     ]
   },
-  "autoPublish": true,
-  "//sampleConfiguration": {
-    "productName": "",
-    "productSlugs": [
-      "azure"
-    ],
-    "disableDocsMs": true,
-    "apiRefLink": "https://docs.microsoft.com/javascript/api/@azure/arm-subscriptions?view=azure-node-preview"
-  }
-}
+  "autoPublish": true
+}

sdk/subscription/arm-subscriptions/review/arm-subscriptions.api.md

@@ -32,6 +32,7 @@ export interface AcceptOwnershipStatusResponse {
     readonly acceptOwnershipState?: AcceptOwnership;
     readonly billingOwner?: string;
     displayName?: string;
+    readonly provisioningState?: Provisioning;
     readonly subscriptionId?: string;
     subscriptionTenantId?: string;
     tags?: {
@@ -145,41 +146,36 @@ export interface GetTenantPolicyResponse {
 
 // @public
 export enum KnownAcceptOwnership {
-    // (undocumented)
     Completed = "Completed",
-    // (undocumented)
     Expired = "Expired",
-    // (undocumented)
     Pending = "Pending"
 }
 
 // @public
 export enum KnownCreatedByType {
-    // (undocumented)
     Application = "Application",
-    // (undocumented)
     Key = "Key",
-    // (undocumented)
     ManagedIdentity = "ManagedIdentity",
-    // (undocumented)
     User = "User"
 }
 
+// @public
+export enum KnownProvisioning {
+    Accepted = "Accepted",
+    Pending = "Pending",
+    Succeeded = "Succeeded"
+}
+
 // @public
 export enum KnownProvisioningState {
-    // (undocumented)
     Accepted = "Accepted",
-    // (undocumented)
     Failed = "Failed",
-    // (undocumented)
     Succeeded = "Succeeded"
 }
 
 // @public
 export enum KnownWorkload {
-    // (undocumented)
     DevTest = "DevTest",
-    // (undocumented)
     Production = "Production"
 }
 
@@ -239,6 +235,9 @@ export interface OperationsListOptionalParams extends coreClient.OperationOption
 // @public
 export type OperationsListResponse = OperationListResult;
 
+// @public
+export type Provisioning = string;
+
 // @public
 export type ProvisioningState = string;
 
@@ -296,6 +295,10 @@ export interface Subscription {
     readonly state?: SubscriptionState;
     readonly subscriptionId?: string;
     subscriptionPolicies?: SubscriptionPolicies;
+    tags?: {
+        [propertyName: string]: string;
+    };
+    readonly tenantId?: string;
 }
 
 // @public
@@ -396,7 +399,7 @@ export type SubscriptionEnableResponse = EnabledSubscriptionId;
 
 // @public
 export interface SubscriptionListResult {
-    nextLink: string;
+    nextLink?: string;
     value?: Subscription[];
 }
 

sdk/subscription/arm-subscriptions/src/models/index.ts

@@ -70,6 +70,13 @@ export interface Subscription {
    * NOTE: This property will not be serialized. It can only be populated by the server.
    */
   readonly state?: SubscriptionState;
+  /**
+   * The tenant ID. For example, 00000000-0000-0000-0000-000000000000.
+   * NOTE: This property will not be serialized. It can only be populated by the server.
+   */
+  readonly tenantId?: string;
+  /** Tags for the subscription */
+  tags?: { [propertyName: string]: string };
   /** The subscription policies. */
   subscriptionPolicies?: SubscriptionPolicies;
   /** The authorization source of the request. Valid values are one or more combinations of Legacy, RoleBased, Bypassed, Direct and Management. For example, 'Legacy, RoleBased'. */
@@ -100,7 +107,7 @@ export interface SubscriptionListResult {
   /** An array of subscriptions. */
   value?: Subscription[];
   /** The URL to get the next set of results. */
-  nextLink: string;
+  nextLink?: string;
 }
 
 /** Tenant Ids information. */
@@ -371,6 +378,11 @@ export interface AcceptOwnershipStatusResponse {
    * NOTE: This property will not be serialized. It can only be populated by the server.
    */
   readonly acceptOwnershipState?: AcceptOwnership;
+  /**
+   * The provisioning state of the resource.
+   * NOTE: This property will not be serialized. It can only be populated by the server.
+   */
+  readonly provisioningState?: Provisioning;
   /**
    * UPN of the billing owner
    * NOTE: This property will not be serialized. It can only be populated by the server.
@@ -501,7 +513,9 @@ export interface SubscriptionAcceptOwnershipHeaders {
 
 /** Known values of {@link Workload} that the service accepts. */
 export enum KnownWorkload {
+  /** Production */
   Production = "Production",
+  /** DevTest */
   DevTest = "DevTest"
 }
 
@@ -517,8 +531,11 @@ export type Workload = string;
 
 /** Known values of {@link ProvisioningState} that the service accepts. */
 export enum KnownProvisioningState {
+  /** Accepted */
   Accepted = "Accepted",
+  /** Succeeded */
   Succeeded = "Succeeded",
+  /** Failed */
   Failed = "Failed"
 }
 
@@ -535,8 +552,11 @@ export type ProvisioningState = string;
 
 /** Known values of {@link AcceptOwnership} that the service accepts. */
 export enum KnownAcceptOwnership {
+  /** Pending */
   Pending = "Pending",
+  /** Completed */
   Completed = "Completed",
+  /** Expired */
   Expired = "Expired"
 }
 
@@ -553,9 +573,13 @@ export type AcceptOwnership = string;
 
 /** Known values of {@link CreatedByType} that the service accepts. */
 export enum KnownCreatedByType {
+  /** User */
   User = "User",
+  /** Application */
   Application = "Application",
+  /** ManagedIdentity */
   ManagedIdentity = "ManagedIdentity",
+  /** Key */
   Key = "Key"
 }
 
@@ -570,6 +594,27 @@ export enum KnownCreatedByType {
  * **Key**
  */
 export type CreatedByType = string;
+
+/** Known values of {@link Provisioning} that the service accepts. */
+export enum KnownProvisioning {
+  /** Pending */
+  Pending = "Pending",
+  /** Accepted */
+  Accepted = "Accepted",
+  /** Succeeded */
+  Succeeded = "Succeeded"
+}
+
+/**
+ * Defines values for Provisioning. \
+ * {@link KnownProvisioning} can be used interchangeably with Provisioning,
+ *  this enum contains the known values that the service supports.
+ * ### Known values supported by the service
+ * **Pending** \
+ * **Accepted** \
+ * **Succeeded**
+ */
+export type Provisioning = string;
 /** Defines values for SubscriptionState. */
 export type SubscriptionState =
   | "Enabled"

sdk/subscription/arm-subscriptions/src/models/mappers.ts

@@ -114,6 +114,20 @@ export const Subscription: coreClient.CompositeMapper = {
           allowedValues: ["Enabled", "Warned", "PastDue", "Disabled", "Deleted"]
         }
       },
+      tenantId: {
+        serializedName: "tenantId",
+        readOnly: true,
+        type: {
+          name: "String"
+        }
+      },
+      tags: {
+        serializedName: "tags",
+        type: {
+          name: "Dictionary",
+          value: { type: { name: "String" } }
+        }
+      },
       subscriptionPolicies: {
         serializedName: "subscriptionPolicies",
         type: {
@@ -181,7 +195,6 @@ export const SubscriptionListResult: coreClient.CompositeMapper = {
       },
       nextLink: {
         serializedName: "nextLink",
-        required: true,
         type: {
           name: "String"
         }
@@ -804,6 +817,13 @@ export const AcceptOwnershipStatusResponse: coreClient.CompositeMapper = {
           name: "String"
         }
       },
+      provisioningState: {
+        serializedName: "provisioningState",
+        readOnly: true,
+        type: {
+          name: "String"
+        }
+      },
       billingOwner: {
         serializedName: "billingOwner",
         readOnly: true,

sdk/subscription/arm-subscriptions/src/subscriptionClient.ts

@@ -54,7 +54,7 @@ export class SubscriptionClient extends coreClient.ServiceClient {
       credential: credentials
     };
 
-    const packageDetails = `azsdk-js-arm-subscriptions/5.0.2`;
+    const packageDetails = `azsdk-js-arm-subscriptions/5.1.0`;
     const userAgentPrefix =
       options.userAgentOptions && options.userAgentOptions.userAgentPrefix
         ? `${options.userAgentOptions.userAgentPrefix} ${packageDetails}`