Skip to content

introduce Client.methodCallWithTransport #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

introduce Client.methodCallWithTransport #123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion lib/client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,24 @@ function Client(options, isSecure) {
* - {mixed} value - The value returned in the method response.
*/
Client.prototype.methodCall = function methodCall(method, params, callback) {
var transport = this.isSecure ? https : http
this.methodCallWithTransport(transport, method, params, callback)
};

/**
* Makes an XML-RPC call to the server specified by the constructor's options
* via the specified transport.
*
* @param {Object} transport - The request transport.
* @param {String} method - The method name.
* @param {Array} params - Params to send in the call.
* @param {Function} callback - function(error, value) { ... }
* - {Object|null} error - Any errors when making the call, otherwise null.
* - {mixed} value - The value returned in the method response.
*/
Client.prototype.methodCallWithTransport = function methodCallWithTransport(transport, method, params, callback) {
var options = this.options
var xml = Serializer.serializeMethodCall(method, params, options.encoding)
var transport = this.isSecure ? https : http

options.headers['Content-Length'] = Buffer.byteLength(xml, 'utf8')
this.headersProcessors.composeRequest(options.headers)
Expand Down