Skip to content

Fix SyntaxWarning: "is" and "is not" with a literal #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix SyntaxWarning: "is" and "is not" with a literal #110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions gsmmodem/modem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -797,13 +797,13 @@ def ownNumber(self):
response = self.write('AT+CPBS?')
selected_phonebook = response[0][6:].split('"')[1] # first line, remove the +CSCS: prefix, split, first parameter

if selected_phonebook is not "ON":
if selected_phonebook != "ON":
self.write('AT+CPBS="ON"')

response = self.write("AT+CPBR=1")
self.write('AT+CPBS="{0}"'.format(selected_phonebook))

if response is "OK": # command is supported, but no number is set
if response == "OK": # command is supported, but no number is set
return None
elif len(response) == 2: # OK and phone number. Actual number is in the first line, second parameter, and is placed inside quotation marks
cnumLine = response[0]
Expand All @@ -823,7 +823,7 @@ def ownNumber(self):
@ownNumber.setter
def ownNumber(self, phone_number):
actual_phonebook = self.write('AT+CPBS?')
if actual_phonebook is not "ON":
if actual_phonebook != "ON":
self.write('AT+CPBS="ON"')
self.write('AT+CPBW=1,"' + phone_number + '"')

Expand Down