Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restic backups - can fail on lost+found directory #1033

Closed
tesshuflower opened this issue Dec 18, 2023 · 5 comments · Fixed by #1043
Closed

Restic backups - can fail on lost+found directory #1033

tesshuflower opened this issue Dec 18, 2023 · 5 comments · Fixed by #1043
Assignees
Labels
bug Something isn't working

Comments

@tesshuflower
Copy link
Contributor

Describe the bug

Restic backups may fail due to lost+found directory created for ext4 filesystems. Should exclude this dir from restic backups.

Steps to reproduce

Expected behavior

Actual results

Additional context

@tesshuflower
Copy link
Contributor Author

Reported by @erenfro .

Interestingly, we do have ext4 in use in e2e tests that run on OpenShift in AWS, however they haven't caught this. My best guess is it's because in OpenShift fsGroup is set automatically and lost+found ends up being readable by the group.

@erenfro Do you currently set fsGroup in your spec.restic.moverSecurityContext?

@erenfro
Copy link

erenfro commented Dec 19, 2023

I don't generally set that, but despite that, lost+found technically should always ever be root:root owned, as this is an innate part of the filesystem design itself. It simply should not be included in the backup regardless of what permissions it has.

@erenfro
Copy link

erenfro commented Dec 19, 2023

And actually, by default, yes, it's actually set in my moverSecurityContext template I use.

@tesshuflower
Copy link
Contributor Author

And actually, by default, yes, it's actually set in my moverSecurityContext template I use.

thx for the confirmation

@erenfro
Copy link

erenfro commented Dec 19, 2023

For reference, I use this setup for my VolSync, in a templated fashion:
Template: https://github.com/erenfro/homelab-flux/tree/main/kubernetes/templates/volsync
Application: https://github.com/erenfro/homelab-flux/tree/main/kubernetes/apps/selfhosted/mealie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants