Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude lost+found for restic #1043

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

tesshuflower
Copy link
Contributor

Describe what this PR does
Excludes lost+found from restic backups

fixes: #1033

Is there anything that requires special attention?

Related issues:

Signed-off-by: Tesshu Flower <[email protected]>
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.9%. Comparing base (9f5cb6a) to head (bc2c74f).
Report is 482 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1043     +/-   ##
=======================================
- Coverage   67.0%   66.9%   -0.2%     
=======================================
  Files         55      55             
  Lines       7080    7080             
=======================================
- Hits        4748    4739      -9     
- Misses      2055    2061      +6     
- Partials     277     280      +3     

see 1 file with indirect coverage changes

@tesshuflower
Copy link
Contributor Author

/cc @JohnStrunk

@openshift-ci openshift-ci bot requested a review from JohnStrunk December 19, 2023 20:39
Copy link
Member

@JohnStrunk JohnStrunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Dec 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnStrunk, tesshuflower

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JohnStrunk,tesshuflower]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 9ae2bb4 into backube:main Dec 19, 2023
24 checks passed
@tesshuflower tesshuflower deleted the restic_lostfound branch December 19, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restic backups - can fail on lost+found directory
2 participants