Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hope/help command #81

Closed
wants to merge 5 commits into from
Closed

Hope/help command #81

wants to merge 5 commits into from

Conversation

hopeyen
Copy link
Collaborator

@hopeyen hopeyen commented May 8, 2021

Added the help command as well as instructional text for sendMoney

@hopeyen hopeyen requested a review from Sladuca May 8, 2021 01:46
@vercel
Copy link

vercel bot commented May 8, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/baf-wallet/baf-wallet-v2/5hmAzkpZYV2x1T77YhvfuZ2ER4ar
✅ Preview: Failed

Sladuca
Sladuca requested changes May 8, 2021
View reviewed changes
Copy link
Contributor

@Sladuca Sladuca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! A bit confused why frontend code is changing for this. Perhaps this branch is based off of hope/formValidation instead of main?

apps/bot/src/commands/Help.ts
});
}

public async run(message: Message): Promise<void> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fmt with nx format. This reminds me I need to add it as a pre-commit hook

apps/bot/src/config/config.ts
@@ -3,8 +3,8 @@ import { BotSettings } from '../types';
export const settings: BotSettings = {
presence: {
activity: {
name: 'Just HODL',
type: 'PLAYING',
name: 'AoT',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chef's kiss

apps/frontend/src/components/ApproveRedirect.svelte
@@ -5,14 +5,18 @@
import AmountFormatter from '@baf-wallet/base-components/AmountFormatter.svelte';
import { BafError } from '@baf-wallet/errors';
import Spinner from 'svelte-spinner';


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is the frontend code being modified here? Did you make this branch off of main or hope/formValidation?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hope/formValidation. Now I see that I should've used main

This was linked to issues May 11, 2021
Add a "help" command to the bot #66
Open
Add helpful text to bot's sendMoney response #71
Open
@vercel
Copy link

vercel bot commented May 15, 2021

Deployment failed with the following error:

The most recent charge for your active payment method has failed. Please update it here: https://vercel.com/teams/baf-wallet/settings/billing.

@hopeyen hopeyen requested a review from Sladuca May 15, 2021 17:00
@Sladuca
Copy link
Contributor

Sladuca commented May 16, 2021

Oh I forgot to mention this got implemented elsewhere while you were on vacation - seriously no hard feelings :).

@Sladuca Sladuca closed this May 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sladuca Sladuca Awaiting requested review from Sladuca

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add helpful text to bot's sendMoney response Add a "help" command to the bot
2 participants
@hopeyen @Sladuca