Skip to content

Remove orphan entry in namespace #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
yvxiang wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove orphan entry in namespace #888

yvxiang wants to merge 2 commits into from

Conversation

@yvxiang
Copy link
Collaborator

@yvxiang yvxiang commented Mar 28, 2017

(#887)

lylei
lylei reviewed Mar 28, 2017
View reviewed changes
src/nameserver/namespace.cc Outdated
}
LOG(INFO, "Check orphan done, %lu entries", orphan_entrys.size());
if (FLAGS_remove_orphan_entry) {
for (std::vector<std::pair<std::string, std::string> >::iterator it =
Copy link
Collaborator

@lylei lylei Mar 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这是一坨啥。。。为啥不用auto

Copy link
Collaborator Author

@yvxiang yvxiang Mar 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已整改

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lylei lylei lylei left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yvxiang @lylei