Support Kafka Streams built-in dead letter queue#179
Draft
philipp94831 wants to merge 7 commits into
Draft
Conversation
philipp94831
commented
Apr 15, 2026
| final byte[] bytes = this.client.retrieveBytes(data, headers, this.isKey); | ||
| final T deserialized = this.deserializer.deserialize(topic, headers, bytes); | ||
| // remove all headers associated with large message because the record might be serialized with different flags | ||
| headers.remove(getHeaderName(this.isKey)); |
Member
Author
There was a problem hiding this comment.
I am not happy about this change but it is necessary in order to make dlq work. dlq uses the most recent headers but the original bytes. Thus, the headers would be unavailable in dlq topic and we cannot deserialize the message. However, we would keep this headers for all down stream messages forever
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.