Fix `BFields` of generated immutable `BRecords` not being marked as `SymbolFlags.READONLY` #42521

Thushara-Piyasekara · 2024-04-09T12:34:22Z

Purpose

Approach

After a discussion with @heshanpadmasiri, it was apparent the InherentTypeViolation error for BFields of readonly BRecords were not getting triggered. This was due to the mutable BRecord generation not inheriting the readonly flag to the generated BFields.

After refactoring the logic to make the BFields also inherit the readonly flag, both cases mentioned in #42520 triggered the same error.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

...est/java/org/ballerinalang/test/types/readonly/TupleVsArrayReadonlyErrorConsistencyTest.java

github-actions · 2024-04-26T19:33:09Z

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

...est/java/org/ballerinalang/test/types/readonly/TupleVsArrayReadonlyErrorConsistencyTest.java

github-actions · 2024-05-22T19:33:13Z

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

github-actions · 2024-06-07T19:33:25Z

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

github-actions · 2024-06-12T19:33:16Z

Closed PR due to inactivity for more than 18 days.

…tency

codecov · 2024-06-24T18:55:04Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.35%. Comparing base (4d2abe5) to head (fab7ee8).
Report is 6 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #42521      +/-   ##
============================================
+ Coverage     77.34%   77.35%   +0.01%     
- Complexity    58587    58592       +5     
============================================
  Files          3460     3460              
  Lines        219862   219860       -2     
  Branches      28914    28914              
============================================
+ Hits         170055   170077      +22     
+ Misses        40391    40368      -23     
+ Partials       9416     9415       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

...erina-unit-test/src/test/java/org/ballerinalang/test/javainterop/basic/StaticMethodTest.java

...est/java/org/ballerinalang/test/types/readonly/TupleVsArrayReadonlyErrorConsistencyTest.java

github-actions · 2024-07-17T19:33:48Z

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

github-actions · 2024-08-05T19:33:18Z

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

github-actions · 2024-08-22T19:33:45Z

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

github-actions · 2024-09-08T19:33:38Z

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

…ina-lang into fix-error-code-inconsistency

MaryamZi · 2024-09-19T07:47:45Z

...t/java/org/ballerinalang/test/expressions/mappingconstructor/MappingConstructorExprTest.java

+    private CompileResult resultWithTupleUpdateMethod;
+    private CompileResult resultWithoutTupleUpdateMethod;


Can't the tests be merged to a single file, with different functions?

Make them local variables anyway. Add comments to say what's being tested.

MaryamZi · 2024-09-19T07:49:10Z

...t/java/org/ballerinalang/test/expressions/mappingconstructor/MappingConstructorExprTest.java

+                BCompileUtil.compile("test-src/types/readonly/test_tuple_vs_array_readonly_violation_consistency.bal");
+        resultWithoutTupleUpdateMethod = BCompileUtil.compile("test-src/types/readonly/" +
+                "test_tuple_vs_array_readonly_violation_consistency_without_tuple_Update_method.bal");


consistency doesn't make sense for the file name.

MaryamZi · 2024-09-19T07:51:38Z

...erina-unit-test/src/test/java/org/ballerinalang/test/javainterop/basic/StaticMethodTest.java

+            expectedExceptionsMessageRegExp = "error: \\{ballerina/lang.map}InherentTypeViolation \\{\"message\":" +
+                    "\"cannot update 'readonly' field 'name' in record of type 'Details & readonly'\".*")
    public void testCreateDetails() {
        BRunUtil.invoke(result, "testCreateDetails");


If the entire record is immutable, the former error is better?

MaryamZi · 2024-09-19T07:52:20Z

...est/resources/test-src/types/readonly/test_tuple_vs_array_readonly_violation_consistency.bal

+    test:assertEquals((<error>actualError).message(), "{ballerina/lang.map}InherentTypeViolation");
+    test:assertEquals((<error>actualError).detail()["message"],


Extract <error>actualError out to a variable.

Thushara-Piyasekara marked this pull request as ready for review April 9, 2024 12:53

Thushara-Piyasekara requested a review from warunalakshitha as a code owner April 9, 2024 12:53

Thushara-Piyasekara marked this pull request as draft April 10, 2024 01:39

Thushara-Piyasekara force-pushed the fix-error-code-inconsistency branch 2 times, most recently from 98020f7 to a96071c Compare April 10, 2024 04:45

Fix immutable BFields not being marked as readonly

2c173b0

Thushara-Piyasekara force-pushed the fix-error-code-inconsistency branch from a96071c to 26702f7 Compare April 10, 2024 04:46

Update tests with new error message

3e017ec

Thushara-Piyasekara force-pushed the fix-error-code-inconsistency branch from 26702f7 to 3e017ec Compare April 10, 2024 05:04

Thushara-Piyasekara marked this pull request as ready for review April 10, 2024 05:25

Thushara-Piyasekara added 2 commits April 10, 2024 13:19

Add tests for InherentTypeViolation consistency

a4c0d33

Fix CheckStyle violations

3ef373e

nipunayf reviewed Apr 11, 2024

View reviewed changes

...est/java/org/ballerinalang/test/types/readonly/TupleVsArrayReadonlyErrorConsistencyTest.java Outdated Show resolved Hide resolved

Add license headers

6e9b1d9

Thushara-Piyasekara mentioned this pull request Apr 22, 2024

[Task]: Codegen optimization for Ballerina #41973

Open

github-actions bot added the Stale label Apr 26, 2024

nipunayf removed the Stale label Apr 27, 2024

warunalakshitha reviewed Apr 29, 2024

View reviewed changes

...est/java/org/ballerinalang/test/types/readonly/TupleVsArrayReadonlyErrorConsistencyTest.java Outdated Show resolved Hide resolved

Update JavaDoc comments for classes

1dbfc97

github-actions bot added the Stale label May 22, 2024

nipunayf removed the Stale label May 23, 2024

github-actions bot added the Stale label Jun 7, 2024

github-actions bot closed this Jun 12, 2024

Merge branch 'ballerina-platform:master' into fix-error-code-inconsis…

27bcd4a

…tency

SasinduDilshara removed the Stale label Jun 24, 2024

SasinduDilshara reopened this Jun 24, 2024

MaryamZi reviewed Jul 1, 2024

View reviewed changes

github-actions bot added Stale and removed Stale labels Jul 17, 2024

github-actions bot added the Stale label Aug 5, 2024

nipunayf removed the Stale label Aug 6, 2024

github-actions bot added Stale and removed Stale labels Aug 22, 2024

github-actions bot added the Stale label Sep 8, 2024

keizer619 removed the Stale label Sep 9, 2024

gimantha requested a review from SasinduDilshara September 9, 2024 05:48

SasinduDilshara added 2 commits September 9, 2024 15:39

add mapping readonly field tests

60e89bf

Merge branch 'master' of https://github.com/ballerina-platform/baller…

b7ed66c

…ina-lang into fix-error-code-inconsistency

SasinduDilshara requested a review from MaryamZi September 9, 2024 10:28

gimantha marked this pull request as draft September 10, 2024 03:34

Fix the error message in readonly field tests

fab7ee8

SasinduDilshara marked this pull request as ready for review September 10, 2024 05:45

MaryamZi reviewed Sep 19, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix `BFields` of generated immutable `BRecords` not being marked as `SymbolFlags.READONLY` #42521

Fix `BFields` of generated immutable `BRecords` not being marked as `SymbolFlags.READONLY` #42521

Thushara-Piyasekara commented Apr 9, 2024 •

edited

Loading

github-actions bot commented Apr 26, 2024

github-actions bot commented May 22, 2024

github-actions bot commented Jun 7, 2024

github-actions bot commented Jun 12, 2024

codecov bot commented Jun 24, 2024 •

edited

Loading

github-actions bot commented Jul 17, 2024

github-actions bot commented Aug 5, 2024

github-actions bot commented Aug 22, 2024

github-actions bot commented Sep 8, 2024

MaryamZi Sep 19, 2024

MaryamZi Sep 19, 2024

MaryamZi Sep 19, 2024

MaryamZi Sep 19, 2024

MaryamZi Sep 19, 2024

		private CompileResult resultWithTupleUpdateMethod;
		private CompileResult resultWithoutTupleUpdateMethod;

		test:assertEquals((<error>actualError).message(), "{ballerina/lang.map}InherentTypeViolation");
		test:assertEquals((<error>actualError).detail()["message"],

Fix BFields of generated immutable BRecords not being marked as SymbolFlags.READONLY #42521

Are you sure you want to change the base?

Fix BFields of generated immutable BRecords not being marked as SymbolFlags.READONLY #42521

Conversation

Thushara-Piyasekara commented Apr 9, 2024 • edited Loading

Purpose

Approach

Samples

Remarks

Check List

github-actions bot commented Apr 26, 2024

github-actions bot commented May 22, 2024

github-actions bot commented Jun 7, 2024

github-actions bot commented Jun 12, 2024

codecov bot commented Jun 24, 2024 • edited Loading

Codecov Report

github-actions bot commented Jul 17, 2024

github-actions bot commented Aug 5, 2024

github-actions bot commented Aug 22, 2024

github-actions bot commented Sep 8, 2024

MaryamZi Sep 19, 2024

Choose a reason for hiding this comment

MaryamZi Sep 19, 2024

Choose a reason for hiding this comment

MaryamZi Sep 19, 2024

Choose a reason for hiding this comment

MaryamZi Sep 19, 2024

Choose a reason for hiding this comment

MaryamZi Sep 19, 2024

Choose a reason for hiding this comment

Fix `BFields` of generated immutable `BRecords` not being marked as `SymbolFlags.READONLY` #42521

Fix `BFields` of generated immutable `BRecords` not being marked as `SymbolFlags.READONLY` #42521

Thushara-Piyasekara commented Apr 9, 2024 •

edited

Loading

codecov bot commented Jun 24, 2024 •

edited

Loading