-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactoring] Fix usage of rawtypes #42889
[Refactoring] Fix usage of rawtypes #42889
Conversation
@Shadow-Devil seemslike there few conflicts in the PR branch, Can you look into that? |
@Shadow-Devil can you please resolve the conflicts in the PR? |
@SasinduDilshara conflicts are resolved |
@SasinduDilshara will you be able to review this now that all checks have passed and no more conflicts are present? |
d3eb8e9
to
23099d2
Compare
There were some merge conflicts which I have resolved |
Could someone merge this please, since it was already approved for quite some time? Thank you in advance 😄 |
ccb6773
to
fa60d10
Compare
Fixed merge conflicts via rebase |
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
8dbcdf9
to
9cde175
Compare
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
5c4fe9d
to
d410682
Compare
… to return type: Required type: Set <Entry<K, V>> Provided type: LinkedHashSet<List<Entry<K, V>>>
d410682
to
59925ec
Compare
@Shadow-Devil Still the windows build pipeline is failing |
With a very strange error:
@gimantha Could you only restart the windows pipeline please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bindgen tool, debugger and json-to-record converter related changes LGTM
Purpose
To ensure type-safety, generics should always be filled out (= no more raw types).
Some issues I encountered:
List<Object>
to aList<String>
. For this I used the approach from this Stackoverflow post to castList<Object>
->List<?>
->List<String>
.ServiceLoader.load(Service.class)
which does not work with generics.TableValueImpl.entrySet()
there was a type error which I could only fix with a semantic change. But I think this was a bug.Approach
Samples
Remarks
Check List