[Refactoring] Fix constant expressions

[Shadow-Devil]

Purpose

Expressions that have been reported by IntelliJ to be constant so they can either be replaced by the constant value or removed entirely (e.g. if(true)).
Closes #43034

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

• Read the Contributing Guide
• Updated Change Log
• Checked Tooling Support (#)
• Added necessary tests
  • Unit Tests
  • Spec Conformance Tests
  • Integration Tests
  • Ballerina By Example Tests
• Increased Test Coverage
• Added necessary documentation
  • API documentation
  • Module documentation in Module.md files
  • Ballerina By Examples

[codecov]

Codecov Report

Attention: Patch coverage is 46.85714% with 93 lines in your changes missing coverage. Please review.

Project coverage is 77.32%. Comparing base (50d8551) to head (ec4016c).
Report is 62 commits behind head on master.

Files with missing lines	Patch %	Lines
.../ballerina/runtime/internal/TableOmDataSource.java	0.00%	27 Missing ⚠️
.../io/ballerina/cli/task/RunNativeImageTestTask.java	21.73%	16 Missing and 2 partials ⚠️
...ntime/transactions/TransactionResourceManager.java	0.00%	13 Missing ⚠️
...nalang/langserver/common/utils/AnnotationUtil.java	28.57%	2 Missing and 3 partials ⚠️
...ava/io/ballerina/runtime/internal/TypeChecker.java	0.00%	0 Missing and 2 partials ⚠️
...ng/compiler/packaging/converters/URIConverter.java	0.00%	2 Missing ⚠️
.../compiler/semantics/analyzer/DataflowAnalyzer.java	89.47%	1 Missing and 1 partial ⚠️
...alang/compiler/semantics/analyzer/TypeChecker.java	60.00%	1 Missing and 1 partial ⚠️
...rina/compiler/internal/parser/BallerinaParser.java	75.00%	1 Missing and 1 partial ⚠️
.../ballerina/runtime/internal/JsonInternalUtils.java	0.00%	0 Missing and 1 partial ⚠️
... and 19 more

Additional details and impacted files

@@            Coverage Diff            @@
##             master   #43035   +/-   ##
=========================================
  Coverage     77.32%   77.32%           
  Complexity    58536    58536           
=========================================
  Files          3460     3460           
  Lines        220048   219982   -66     
  Branches      28902    28872   -30     
=========================================
- Hits         170152   170107   -45     
- Misses        40484    40493    +9     
+ Partials       9412     9382   -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[SasinduDilshara]

in here do we handle mapConstraint == null

[Shadow-Devil]

TypeUtils.getImpliedType was inferred to always return non null values by IntelliJ.

See also the definition of TypeUtils.getImpliedType:

ballerina-lang/bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/api/utils/TypeUtils.java

Lines 176 to 190 in c0c17f8

	public static Type getImpliedType(Type type) {
	Type impliedType = type.getCachedImpliedType();
	if (impliedType != null) {
	return impliedType;
	}
	type = getReferredType(type);
	if (type.getTag() == TypeTags.INTERSECTION_TAG) {
	impliedType = getImpliedType(((IntersectionType) type).getEffectiveType());
	} else {
	impliedType = type;
	}
	type.setCachedImpliedType(impliedType);
	return impliedType;
	}

It recursively calls itself until it finds a non null value or returns whatever getReferredType returns, but this has to be not null, since we access type.getTag().

[github-actions]

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

[Shadow-Devil]

Remove stale status

[github-actions]

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

[github-actions]

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.