-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Gson
library usage from the Profiler
#43103
base: master
Are you sure you want to change the base?
Remove Gson
library usage from the Profiler
#43103
Conversation
I think this also fixes #42900 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #43103 +/- ##
============================================
- Coverage 77.52% 77.51% -0.01%
+ Complexity 58587 58585 -2
============================================
Files 3438 3438
Lines 219216 219225 +9
Branches 28919 28923 +4
============================================
- Hits 169938 169930 -8
- Misses 39860 39875 +15
- Partials 9418 9420 +2 ☔ View full report in Codecov by Sentry. |
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
Closed PR due to inactivity for more than 18 days. |
The code coverage for the PR is low because the functionality to be tested is under a shutdown hook. This issue is already tracked #43071 separately. |
Lets fix the merge conflicts and get this merge. |
It seems like the
test is flaky, I also noticed it sometimes failing/succeeding in my PRs without any changes. |
Purpose
Fixes #43073 , Fixes #42900
Check List