Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Gson library usage from the Profiler #43103

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

ravinperera00
Copy link
Contributor

@ravinperera00 ravinperera00 commented Jul 16, 2024

Purpose

The suggested changes will refactor the code to remove the use of Gson library from the Profiler tool using other internal alternatives.

Fixes #43073 , Fixes #42900

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@ravinperera00 ravinperera00 marked this pull request as ready for review July 17, 2024 12:21
@Shadow-Devil
Copy link
Contributor

I think this also fixes #42900

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 77.51%. Comparing base (a4f8a51) to head (cf40da8).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
...a/io/ballerina/runtime/profiler/ui/JsonParser.java 0.00% 24 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #43103      +/-   ##
============================================
- Coverage     77.52%   77.51%   -0.01%     
+ Complexity    58587    58585       -2     
============================================
  Files          3438     3438              
  Lines        219216   219225       +9     
  Branches      28919    28923       +4     
============================================
- Hits         169938   169930       -8     
- Misses        39860    39875      +15     
- Partials       9418     9420       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Aug 3, 2024

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Aug 3, 2024
@HindujaB HindujaB removed the Stale label Aug 5, 2024
Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Aug 21, 2024
Copy link

Closed PR due to inactivity for more than 18 days.

@github-actions github-actions bot closed this Aug 25, 2024
@github-actions github-actions bot removed the Stale label Sep 4, 2024
@ravinperera00
Copy link
Contributor Author

ravinperera00 commented Sep 6, 2024

The code coverage for the PR is low because the functionality to be tested is under a shutdown hook. This issue is already tracked #43071 separately.

@warunalakshitha
Copy link
Contributor

Lets fix the merge conflicts and get this merge.

@Shadow-Devil
Copy link
Contributor

It seems like the

:language-server:language-server-core:test  
org.ballerinalang.langserver.diagnostics.CyclicDependenciesTest.testCyclicDependenciesOnOpen[1]

test is flaky, I also noticed it sometimes failing/succeeding in my PRs without any changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants