Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare missing Service usage and remove exports to non-existing modules #43401

Merged

Conversation

Shadow-Devil
Copy link
Contributor

Purpose

Some services were not declared that they are used in the module-info.java files. I also cleaned up any exports to non-existing modules (probably relics from the past).

Fixes #

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@Shadow-Devil Shadow-Devil changed the title Declare missing Service usage and remove exports non existing modules Declare missing Service usage and remove exports to non-existing modules Sep 18, 2024
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@8100e00). Learn more about missing BASE report.
Report is 162 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #43401   +/-   ##
=========================================
  Coverage          ?   77.51%           
  Complexity        ?    58586           
=========================================
  Files             ?     3438           
  Lines             ?   219218           
  Branches          ?    28921           
=========================================
  Hits              ?   169919           
  Misses            ?    39884           
  Partials          ?     9415           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gimantha gimantha merged commit f392e37 into ballerina-platform:master Oct 8, 2024
18 checks passed
@Shadow-Devil Shadow-Devil deleted the update-module-info branch October 8, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants