chore(docker): set api.environment.DB_URL
#664
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Docker is the most convenient way to get started. As the docker compose files already define a postgres service with migrations applied.
However the environment variables are set with an
env_file
and the.env.example
uses sqlite. Which is confusing.As a dev:
yarn dev
(because i am making changes and don;t want to rebuild the image every time)Depending on the situation the postgres url will be different (different host:
postgres
orlocalhost
).To accomodate for both situations, one needs either to use different
.env
files (e.g.env.local
and.env.docker
).Or one can override the
env_file
by settingenvironment.DB_URL
in docker compose.This PR does the latter.
Does this introduce a breaking change?
Checklist
yarn prettier
andyarn lint
without getting any errorsImportant
We do not accept minor grammatical fixes (e.g., correcting typos, rewording sentences) unless they significantly improve clarity in technical documentation. These contributions, while appreciated, are not a priority for merging. If there is a grammatical error feel free to message the team.