Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 数据源创建失败缺少cause(#653) #657

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

alvinkwok1
Copy link
Contributor

@alvinkwok1 alvinkwok1 commented Jul 21, 2024

  1. 修复(创建数据源错误 #653)
  2. 为所有的数据源创建时进行初始化的都添加统一的异常包装返回.

为什么不对延迟加载的也做处理?
我能想到的处理办法时是对原始数据源进行一层wrapper, 都是在getConnection的时候进行初始化的,但是如何对数据源创建失败是一个比较难以判断的事情也没有多大的必要

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style
  • Refactor
  • Doc
  • Other, please describe:

The description of the PR:

Other information:

1. 修复(baomidou#653)
2. 为所有的数据源创建时进行初始化的都添加统一的异常包装返回.

为什么不对延迟加载的也做处理?
我能想到的处理办法时是对原始数据源进行一层wrapper, 都是在getConnection的时候进行初始化的,但是如何对数据源创建失败是一个比较难以判断的事情也没有多大的必要
@huayanYu huayanYu merged commit f93fff4 into baomidou:master Jul 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants