remove unused imports #1404
Open
remove unused imports #1404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davpsh
reviewed
May 12, 2023
| @@ -5,8 +5,6 @@ | |||
| use Closure; | |||
| use DebugBar\DataCollector\DataCollector; | |||
| use DebugBar\DataCollector\Renderable; | |||
| use Illuminate\Http\Request; | |||
| use Illuminate\Routing\Route; | |||
There was a problem hiding this comment.
Yes, it can be removed, since the import is not used anywhere, but I would suggest to keep the import of the Response class and use it here
as Response::class instead of a string value
There was a problem hiding this comment.
you're free to make a separate PR, but I'm going to leave this as is.
davpsh
reviewed
May 12, 2023
| @@ -6,10 +6,8 @@ | |||
| use Barryvdh\Debugbar\DataCollector\CacheCollector; | |||
| use Barryvdh\Debugbar\DataCollector\EventCollector; | |||
| use Barryvdh\Debugbar\DataCollector\FilesCollector; | |||
| use Barryvdh\Debugbar\DataCollector\GateCollector; | |||
There was a problem hiding this comment.
The same suggestions as above - leave the import and use in the code instead of string values
davpsh
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.