Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance: shell markdown #64

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Enhance: shell markdown #64

merged 2 commits into from
Aug 27, 2024

Conversation

Malix-Labs
Copy link
Contributor

@Malix-Labs Malix-Labs commented Aug 26, 2024

Kind of nit anyway

  1. Removing $ make the shell scripts copy-pastable
  2. Scripts are POSIX shell (sh) compliant, which is a subset of bash
  3. Sourcing from sh instead of zsh makes it use the default (POSIX shell compliant) shell, which make the script work even if the user is not using zsh

@bartkessels
Copy link
Owner

Thank you for your help!

@bartkessels bartkessels merged commit c709995 into bartkessels:main Aug 27, 2024
3 checks passed
@Malix-Labs
Copy link
Contributor Author

Sourcing from sh instead of zsh makes it use the default (POSIX shell compliant) shell, which make the script work even if the user is not using zsh

Idk if MacOS is totally *nix compliant on this one, it would need to be tested manually, but it should

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants