Skip to content

Conversation

@jackjohn7
Copy link
Member

@jackjohn7 jackjohn7 commented Aug 19, 2025

  • Update Dockerfile template to use our images with parameterized tags
  • Update Dockerfile rendering to provide appropriate tags for server and client if necessary
  • Clean up a few things in the execution process in Dockerfile

Close #15

@jackjohn7 jackjohn7 self-assigned this Aug 19, 2025
Copy link
Member

@funnyboy-roks funnyboy-roks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few thoughts about potential improvements.

funnyboy-roks
funnyboy-roks previously approved these changes Aug 25, 2025
Copy link
Member

@funnyboy-roks funnyboy-roks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor grammar issue, but otherwise good with me

Co-authored-by: Funny <[email protected]>
@jackjohn7 jackjohn7 merged commit 5b7dabb into main Aug 25, 2025
12 of 13 checks passed
@jackjohn7 jackjohn7 deleted the jack/use-public-images branch August 25, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support event-hook registration

3 participants