Fixed 6 critical bugs in README.md that would break production code #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary Fixed 6 critical bugs in README.md that would break production code: Missing await on provider.request() calls (2 instances) Buffer.from() crashes in browsers - replaced with TextEncoder Incomplete subscription charge example - added full implementation Added error handling section with try-catch examples Added production deployment warning for testnet flag Fixed grammar: "lets" → "let" Impact: Prevents runtime errors and improves developer experience with working, copy-pasteable examples. How did you test your changes? Manually reviewed all code examples for: Correct async/await usage Browser API compatibility (replaced Buffer with TextEncoder) Complete working implementations Proper Markdown formatting Documentation-only changes - no runtime tests required.
🟡 Heimdall Review Status
|
|
|
||
| ```js | ||
| const addresses = provider.request({ | ||
| const addresses = await provider.request({ |
There was a problem hiding this comment.
This is a good catch
Hey @spencerstock, thanks for the feedback! Ready to merge, or is there anything else I should do? 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed 6 critical bugs in README.md that would break production code:
awaitonprovider.request()calls (2 instances)Buffer.from()crashes in browsers - replaced withTextEncoderImpact: Prevents runtime errors and improves developer experience with working, copy-pasteable examples.
How did you test your changes?
Manually reviewed all code examples for:
Documentation-only changes - no runtime tests required.