fixed typos and removed print #521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Heimdall Review Status
|
JenabaBa
reviewed
Aug 4, 2025
| @@ -153,7 +153,7 @@ func createCommitMessage(updatedDependencies []VersionUpdateInfo, repoPath strin | |||
| } else if !githubAction { | |||
| cmd := exec.Command("git", "commit", "-am", commitTitle, "-m", commitDescription) | |||
| if err := cmd.Run(); err != nil { | |||
| return fmt.Errorf("error running git commit -m: %s", err) | |||
| return fmt.Errorf("running git commit -m: %s", err) | |||
There was a problem hiding this comment.
is there a reason for removing the error in front? ex. here
There was a problem hiding this comment.
makes it a bit unclear and sounds like "running git commit -m" is currently being run
There was a problem hiding this comment.
hmm, yeah, that's my mistake. Sorry for that
makes it a bit unclear and sounds like "running git commit -m" is currently being run
There was a problem hiding this comment.
np! other changes are fine
There was a problem hiding this comment.
maybe just
return fmt.Errorf("failed to run git commit -m: %s", err)
JenabaBa
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edited error messages
Removed debug print