Skip to content

Conversation

amiecorso
Copy link
Contributor

@amiecorso amiecorso commented Aug 22, 2025

What changed? Why?
This adds the ability to register basenames (including signing to set the name as primary name in the L2ReverseRegistrar) for EOAs with the new ENSIP-19 compliant contracts.

Notes to reviewers

@arjun-dureja I branched from your SCW registration flow branch to avoid duplicate work, but when I change the base branch here to your branch I see too many changes (this may be because I have changed merged into my branch from master that aren't in yours)

hopefully will settle out when your branch merges down and/or picks up changes from master and we can see a clean diff

How has it been tested?

RegisterENSIP19EOA.mov

Have you tested the following pages?

BaseWeb

  • [] base.org
  • [] base.org/names
  • [] base.org/builders
  • [] base.org/ecosystem
  • [] base.org/name/jesse
  • [] base.org/manage-names
  • [] base.org/resources

Copy link

linear bot commented Aug 22, 2025

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Aug 22, 2025

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Copy link

vercel bot commented Aug 22, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
base-web Ready Ready Preview Comment Sep 9, 2025 10:33pm

@amiecorso amiecorso changed the base branch from master to arjun/ensip19-registration September 9, 2025 21:09
@amiecorso amiecorso changed the base branch from arjun/ensip19-registration to master September 9, 2025 21:09
@amiecorso amiecorso changed the base branch from master to arjun/ensip19-registration September 9, 2025 22:31
@amiecorso amiecorso changed the base branch from arjun/ensip19-registration to master September 9, 2025 22:31
@amiecorso amiecorso marked this pull request as ready for review September 9, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants