Mobile: Bridge components #2307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayohms
reviewed
Jan 7, 2026
It sends all buttons in one connect payload.
jayohms
reviewed
Jan 7, 2026
svara
commented
Jan 8, 2026
app/javascript/bridge/controllers/bridge/overflow_menu_controller.js
Outdated
Show resolved
Hide resolved
adjogima
reviewed
Jan 8, 2026
Contributor
|
Considering how we decided to move the app related CSS files into the existing structure, should we do the same here? or even flat, like: |
…rget button can be included
... to fix in the native apps
jayohms
reviewed
Jan 12, 2026
... for template caching
* main: Remove explicit queue definition Fix attribute name Explicitly define incineration priority Fix incorrect recurring job config Add self-service account deletion (#2246) Document DELETE endpoint for removing card header image Document goldness endpoints for marking cards as golden Document closed and column fields in card API response
* main: (22 commits) Disable card column buttons when active Prevent comment content from overlapping with reaction button Delete pins belonging to cards in a board with revoked access Update development dependencies in SAAS lockfile Update runtime dependencies Update development dependencies Balance magic link instructions Add `.txt-balance` utility Move handleDesktop inside restoreColumnsDisablingTransitions Adjust border radius Clean up blank slates Add dialog manager to events page More sturated mini bubbles in light mode Brighten mini bubbles in dark mode Use separate cache namespaces for each beta instance Bump boost size up a tick on mobile Move Undo form inside closure message element Phrasing tweak for exceeding storage limit Keep strong tags words on same line Allow ActionText embed reuse and safe purge (#2346) ...
* main: Add rollback script to convert relative URLs back to absolute Add a script to migrate existing rich texts to relative URLs Use relative URLs where possible across all the app Use relative URLs for avatars and rich text attachments
* main: Solve problem when Action Text raises on missing attachables Solve problem when Action Text raises on missing attachables Completing a step removes stalled status from UI Bump Bootsnap to v1.21.1 Use correct class selectors to target cards with background images Update lexxy to latest Hide table button for now Table CSS tweaks Update to Lexxy 0.7.0beta Revert "Wrap tables in div" Wrap tables in div CSS updates for `<table>` support Update to latest Lexxy Show only active subscriptions Add paid accounts stats to admin dashboard Keep URLs in webhook events absolute Delete orphaned watches and pins when a card is moved to a private board
jayohms
reviewed
Jan 16, 2026
... instead of a separate dialog focus controller
... to support lazy loaded dialog content
* main: Create popup initial alignment classes Fix class typo Hide the board selector button if card is closed Align board and tag picker dialogs without using math Add dialog manager to card perma Fix "M" hotkey using stale user from fragment cache Add Enable all/Disable all buttons to webhook event selection Remove whitespace Remove hover styles from disabled menu items # Conflicts: # app/views/cards/_container.html.erb
jayohms
reviewed
Jan 19, 2026
* main: Fix notification broadcast test for turbo-rails 2.0.21 Update `turbo-rails` to get latest Turbo version
Collaborator
kevinmcconnell
left a comment
kevinmcconnell
left a comment
There was a problem hiding this comment.
Looks good! I left one very minor question :)
| if block_given? | ||
| form_with **attributes, data: data, & | ||
| else | ||
| form_with(**attributes, data: data) { } |
Collaborator
There was a problem hiding this comment.
I think this makes bridged_form_with behave differently than form_with in the case of no block -- it would make it render an empty form, rather than just an opening form tag. Is this intentional? If not, I think we could do without this conditional, and always pass & to get the matching behaviour.
Contributor
There was a problem hiding this comment.
@svara do you recall why this conditional was added?
Contributor
Author
There was a problem hiding this comment.
I was following the auto_submit_form_with pattern/behaviour.
Collaborator
There was a problem hiding this comment.
Ah, I suspect that one has that because it's commonly used as an empty form. So it's probably there as a convenience.
I'd be tempted to remove it from this one, since bridged_form_with is more of a form wrapper, so you'd expect it to behave more like a regular form_with. It's a very minor thing, though!
Contributor
Author
There was a problem hiding this comment.
I appreciate the explanation @kevinmcconnell.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Hotwire Native Bridge support and components.
Bridge components:
Example usage:
bridged_form_with.Note: CSS has minimal additions to make the examples work.