Change exceeding and nearing limits to account for the 1000th card #2345
Conversation
|
|
||
| def exceeding_card_limit? | ||
| plan.limit_cards? && billed_cards_count > plan.card_limit | ||
| plan.limit_cards? && billed_cards_count >= plan.card_limit |
There was a problem hiding this comment.
Maybe this should be just > so that the account can't simultaneously be near and over the limit?
This conceptually also makes sense - on the free plan you can publish 1000 cards, but you can't publish the 1001st card since it's over the limit.
|
|
||
| def exceeding_card_limit? | ||
| plan.limit_cards? && billed_cards_count > plan.card_limit | ||
| plan.limit_cards? && billed_cards_count >= plan.card_limit |
There was a problem hiding this comment.
Yes, I agree with @monorkin, I think this should be just >.
I am curious, was this causing some user-facing bug in the app?
There was a problem hiding this comment.
The issue is stated well in the Fizzy card. Right now, after you've created 1000 cards and go to create another one, the message says "You've used 1000 of 1000 cards", but you can still create another one (card 1001). Seems like the Upgrade prompt should kick in when you have 1000 cards, not 1001.
There was a problem hiding this comment.
Yeah, I think @andyra's logic is correct here, we want to check for >=. It might be the name that's confusing us: the state we're trying to detect is "reached plan limit", not exceeded it, I think?
Currently, on an account with 1,000 cards…
nearing_plan_cards_limit?✅exceeding_card_limit?🚫Seems like we should use
<=and>=respectively for these checks so that on a plan with 1,000 cards…nearing_plan_cards_limit?🚫exceeding_card_limit?✅https://app.fizzy.do/5986089/cards/3491