change keepalive setting to mean true when specified in Options #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An Erlang developer expects the atoms in options to denote the `true`
boolean value. So, when `keepalive` is in the options we expect that
keepalive feature is turned on.
In theory this is a backward incompatible change but in practice I cannot
imagine anyone setting `[keepalive, ...]` and expecting `[{keepalive, false},
...]` which is the default anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An Erlang developer expects the atoms in options to denote the
trueboolean value. So, when
keepaliveis in the options we expect thatkeepalive feature is turned on.
In theory this is a backward incompatible change but in practice I cannot
imagine anyone setting
[keepalive, ...]and expecting[{keepalive, false}, ...]which is the default anyway.