"Add Message Acknowledgment Mechanism for Exactly-Once Processing" #350
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Message Acknowledgment for Exactly-Once Processing
Summary
Implements message acknowledgment mechanism to support exactly-once processing guarantees, addressing the autoscaling feature (PR #202) where actors with pending messages could be dropped.
Changes
Core Implementation
SignedMessage: Addedack(),acknowledge(), andis_acknowledged()methodsBastionContext: Addedmessage_processed(&SignedMessage)convenience methodContextState: Added unacknowledged message counter for autoscaling integrationAPI Usage
Option 1 - Direct acknowledgment:
Option 2 - Context-based:
Benefits
✅ Exactly-once message processing
✅ Safer autoscaling (prevents dropping actors with pending work)
✅ Thread-safe atomic operations
✅ Backward compatible (opt-in feature)
✅ Comprehensive tests and examples
Files Changed
src/bastion/src/envelope.rs- Added acknowledgment toSignedMessagesrc/bastion/src/context.rs- Added tracking and context methodsrc/bastion/src/message.rs- Pattern matching updatessrc/bastion/examples/message_acknowledgment.rs- Working examplesrc/bastion/tests/message_acknowledgment.rs- Test suiteTesting
cargo test message_acknowledgment cargo run --example message_acknowledgmentAutoscaling Integration
The unacknowledged message counter enables autoscaling to check if actors are safe to remove:
Breaking Changes
None. Fully backward compatible - existing code works unchanged.
Ready for review ✨