#13 Fixes inconsistency in generating legal product IDs between the M…#14
Open
danemacmillan wants to merge 1 commit into
Open
#13 Fixes inconsistency in generating legal product IDs between the M…#14danemacmillan wants to merge 1 commit into
danemacmillan wants to merge 1 commit into
Conversation
…tween the Magento1 and Magento2 module. This ensures that data will continue to get pulled into Magento2 stores when the product ID has a perfectly legal period in it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…agento1 and Magento2 module. This ensures that data will continue to get pulled into Magento2 stores when the product ID has a perfectly legal period in it.
To the best of my sleuthing, the "customization" was probably an experiment was that accidentally committed when the module was ported to Magento2. I cannot think of any good reason why BV would want to cut their customers off of the data they have been generating, by introducing a new regular expression format and banning periods, which are part of Magento product IDs.