Use tags in integration tests #113
Open
+71
−108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sitaktif
force-pushed
the
integ-tests-use-tags
branch
from
653379b to
7146256
Compare
gibfahn
approved these changes
May 22, 2025
| Path path = Files.createTempDirectory("target-determinator-testdata"); | ||
| Git.cloneRepository() | ||
| .setURI("https://github.com/bazel-contrib/target-determinator-testdata.git") | ||
| .setURI("https://github.com/sitaktif/target-determinator-testdata.git") |
Collaborator
There was a problem hiding this comment.
Reminder to revert this before landing.
| public static final String ALIAS_ADD_TARGET_TO_FILE = "7be0f96f26742daec661c2ebfbb08b88b6355a3b"; | ||
|
|
||
| public static final String ALIAS_CHANGE_TARGET_THROUGH_ALIAS_TO_FILE = "68fbd3661f3626e2df6a55b079444adbf76b5a3b"; | ||
| public static final String NO_TARGETS = "v1/new-branch"; |
Collaborator
There was a problem hiding this comment.
Not a blocker, but new-branch always seemed a bit misnamed as a tag to me.
Collaborator
Author
There was a problem hiding this comment.
I agree, I am going to update this.
sitaktif
force-pushed
the
integ-tests-use-tags
branch
from
7146256 to
82ed4e7
Compare
sitaktif
force-pushed
the
integ-tests-use-tags
branch
from
82ed4e7 to
1e5a275
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will makes bazel version updates in the test data much easier.