-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Verify that genhtml accepts the combined report #27396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This provides additional end-to-end assurance on Bazel-generated coverage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds end-to-end validation of Bazel-generated coverage reports by verifying that genhtml can successfully process the generated LCOV files. This provides additional assurance that the coverage data format is correct and compatible with standard LCOV tooling.
Key changes:
- Added
lcovas a dependency to enablegenhtmlvalidation - Updated test files to contain actual content instead of empty files for more realistic coverage scenarios
- Added
genhtmlprocessing verification steps to coverage tests
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| MODULE.bazel | Added lcov dependency (v2.3.1) and reordered Maven dependencies alphabetically |
| src/test/shell/bazel/BUILD | Added genhtml tool as test data and configured GENHTML environment variable for all coverage test targets |
| src/test/shell/bazel/bazel_coverage_starlark_test.sh | Replaced empty test files with files containing actual content and added genhtml validation for coverage and baseline reports |
| src/test/shell/bazel/bazel_coverage_java_test.sh | Added genhtml validation step to verify coverage report can be processed |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
The Windows failure is due to linux-test-project/lcov#442. |
|
@c-mita CI is green now |
This provides additional end-to-end assurance on Bazel-generated coverage.