Skip to content

Conversation

@fmeum
Copy link
Collaborator

@fmeum fmeum commented Oct 23, 2025

This provides additional end-to-end assurance on Bazel-generated coverage.

This provides additional end-to-end assurance on Bazel-generated coverage.
@fmeum fmeum requested a review from c-mita October 23, 2025 12:25
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Oct 23, 2025
@fmeum fmeum marked this pull request as draft October 23, 2025 12:51
@fmeum fmeum requested a review from Copilot October 23, 2025 12:52
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds end-to-end validation of Bazel-generated coverage reports by verifying that genhtml can successfully process the generated LCOV files. This provides additional assurance that the coverage data format is correct and compatible with standard LCOV tooling.

Key changes:

  • Added lcov as a dependency to enable genhtml validation
  • Updated test files to contain actual content instead of empty files for more realistic coverage scenarios
  • Added genhtml processing verification steps to coverage tests

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

File Description
MODULE.bazel Added lcov dependency (v2.3.1) and reordered Maven dependencies alphabetically
src/test/shell/bazel/BUILD Added genhtml tool as test data and configured GENHTML environment variable for all coverage test targets
src/test/shell/bazel/bazel_coverage_starlark_test.sh Replaced empty test files with files containing actual content and added genhtml validation for coverage and baseline reports
src/test/shell/bazel/bazel_coverage_java_test.sh Added genhtml validation step to verify coverage report can be processed

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@fmeum
Copy link
Collaborator Author

fmeum commented Oct 23, 2025

The Windows failure is due to linux-test-project/lcov#442.

@fmeum fmeum marked this pull request as ready for review October 26, 2025 11:04
@fmeum
Copy link
Collaborator Author

fmeum commented Oct 26, 2025

@c-mita CI is green now

@iancha1992 iancha1992 added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Oct 30, 2025
@meteorcloudy meteorcloudy added coverage team-Rules-API API for writing rules/aspects: providers, runfiles, actions, artifacts and removed team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website labels Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-review PR is awaiting review from an assigned reviewer coverage team-Rules-API API for writing rules/aspects: providers, runfiles, actions, artifacts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants