Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ios_ui_test section to have test_host to be required #2474

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update ios_ui_test section to have test_host to be required #2474

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/rules-ios.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,7 +598,7 @@ of the attributes inherited by all test rules, please check the
| <a id="ios_ui_test-runner"></a>runner | The runner target that will provide the logic on how to run the tests. Needs to provide the AppleTestRunnerInfo provider. | <a href="https://bazel.build/concepts/labels">Label</a> | required | |
| <a id="ios_ui_test-test_coverage_manifest"></a>test_coverage_manifest | A file that will be used in lcov export calls to limit the scope of files instrumented with coverage. | <a href="https://bazel.build/concepts/labels">Label</a> | optional | `None` |
| <a id="ios_ui_test-test_filter"></a>test_filter | Test filter string that will be passed into the test runner to select which tests will run. | String | optional | `""` |
| <a id="ios_ui_test-test_host"></a>test_host | - | <a href="https://bazel.build/concepts/labels">Label</a> | optional | `None` |
| <a id="ios_ui_test-test_host"></a>test_host | - | <a href="https://bazel.build/concepts/labels">Label</a> | required | `None` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd have to update the rule attr as well which I believe is shared with the other iOS test rules.

Maybe we could override this attr in the ui test rule so it can have its own documentation

| <a id="ios_ui_test-test_host_is_bundle_loader"></a>test_host_is_bundle_loader | Whether the 'test_host' should be used as the -bundle_loader to allow testing the symbols from the test host app | Boolean | optional | `True` |


Expand Down