Skip to content

Commit

Permalink
Do not require deprecated create_cc_toolchain_config_info attrs
Browse files Browse the repository at this point in the history
BEGIN_PUBLIC

In create_cc_toolchain_config_info, the target_system_name, target_cpu, and target_libc attributes are documented as required and deprecated. In practice, these may safely be `None`. This updates the cc_toolchain rule implementation to no longer require that these attributes are set to arbitrary values.

END_PUBLIC

PiperOrigin-RevId: 633149160
Change-Id: Ief1d3236ead9299b307ce9ace68cd295536a7b3b
  • Loading branch information
Googler authored and copybara-github committed May 13, 2024
1 parent f88663d commit 71d9e52
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions cc/toolchains/impl/toolchain_config.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,9 @@ cc_toolchain_config = rule(
# TODO: Consider making this into a label_list that takes a
# cc_directory_marker rule as input.
"cxx_builtin_include_directories": attr.string_list(),
"target_system_name": attr.string(mandatory = True),
"target_cpu": attr.string(mandatory = True),
"target_libc": attr.string(mandatory = True),
"target_system_name": attr.string(),
"target_cpu": attr.string(),
"target_libc": attr.string(),
"compiler": attr.string(mandatory = True),
"abi_version": attr.string(),
"abi_libc_version": attr.string(),
Expand Down

0 comments on commit 71d9e52

Please sign in to comment.