Support clang-cl to build x86 binaries #360
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike other toolchains defined for Windows, clang-cl toolchain has not supported x86 (32-bit) executables. This can be a hard blocker for projects that consider switching from msvc toolchain to clang-cl with supporting x86 executables. With this commit rules_cc starts providing clang-cl toolchain to build x86 executables. Closes bazelbuild#358.
yukawa
requested review from
trybka,
armandomontanez,
pzembrod,
comius and
c-mita
as code owners
yukawa
added a commit
to yukawa/mozc
that referenced
this pull request
Feb 15, 2025
This is a preparation to build Mozc for Windows with clang-cl (google#1179). This commit pulls my pull request [1] to let rules_cc register clang-cl as a valid toolchain to build x86 (32-bit) Windows executables. While when and how my pull request will get merged into upstream, having these local patches allows us to go ahead to see if we can fully migrate to clang-cl or not. There must be no impact on Bazel with msvc build in this commit. [1]: bazelbuild/rules_cc#360
hiroyuki-komatsu
pushed a commit
to google/mozc
that referenced
this pull request
Feb 18, 2025
This is a preparation to build Mozc for Windows with clang-cl (#1179). This commit pulls my pull request [1] to let rules_cc register clang-cl as a valid toolchain to build x86 (32-bit) Windows executables. While when and how my pull request will get merged into upstream, having these local patches allows us to go ahead to see if we can fully migrate to clang-cl or not. There must be no impact on Bazel with msvc build in this commit. [1]: bazelbuild/rules_cc#360 PiperOrigin-RevId: 728118916
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike other toolchains defined for Windows, clang-cl toolchain has not supported x86 (32-bit) executables. This can be a hard blocker for projects that consider switching from msvc toolchain to clang-cl with supporting x86 executables.
With this commit
rules_ccstarts providing clang-cl toolchain to build x86 executables.Given that protobuf team is planning to stop supporting msvc toolchain in bazel build configurations, clang-cl support in
rules_ccwould become much more important soon.Closes #358.