forked from Dav1dde/glad
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] glad2 from Dav1dde:glad2 #21
Open
pull
wants to merge
130
commits into
bazelregistry:glad2
Choose a base branch
from
Dav1dde:glad2
base: glad2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+33,889
−15,378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Herberth <[email protected]>
EGL loading was failing for a display of EGL_NO_DISPLAY. Allow loading EGL 1.5 and above since eglQueryString supports EGL_NO_DISPLAY in this case.
`wglGetProcAddress` is `APIENTRY` and gets casted into a non APIENTRY function pointer, which leads to issues on platforms that actually use APIENTRY (e.g. win32) closes: #240
also: * updates all the bundled specifications * adds missing Rust types see gh: #243
current warnings: * clippy::missing_safety_doc * clippy::too_many_arguments * clippy::unused_unit * clippy::unreadable_literal disables all warnings to prevent future issues closes: #249
Memoize has an uncapped cache size, the cache is scoped to the global function and never expiring, this attaches the cache to the class instance instead of the function/method. This makes it so the GC has a chance of collecting the instance and with it the cache.
The API in the require was honored before, but when the symbol from one API require referenced the symbol from a different API require through an alias, it was still brought in. gh: #281
this is just a quick fix, if custom_declarations is later required to be always generated, it probably makes sense to have a separate block with better naming gh: #279
closes: #434
Co-authored-by: Oleg Ageev <[email protected]>
Check for a defined variable instead of a 1/0 flag, for symmetry with GLAD_GL, GLAD_GLES2 and other user-facing defines.
Window did not respond properly to closing via the 'x' button. Tested on Windows 10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )