Fix mermaid console errors - #124
Open
paulbrimicombe wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧐 What?
Currently when a Mermaid diagram is included in the page the following errors can be seen in the console:
Screenshot:
This is because the
mermaid.min.jsbundle is imported as an ES Module (usingtype="module") but it is expecting to be imported as a "classic script". When imported as a module, themermaidglobal object fails to be set and the mermaid bundle throws an error. All diagrams still render successfully, however.An ESM version of Mermaid does exist but is difficult to use because:
🛠 How
Removing the
typeattribute from the Mermaid<script>tag eliminates the console errors