-
Notifications
You must be signed in to change notification settings - Fork 262
WS-1943-Create route in Simorgh to render Topic pages in Next.js app #13593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: latest
Are you sure you want to change the base?
WS-1943-Create route in Simorgh to render Topic pages in Next.js app #13593
Conversation
|
Forgot that we'll also need an entry here to handle
|
ws-nextjs-app/pages/[service]/topics/[id]/[[...variant]].page.test.tsx
Outdated
Show resolved
Hide resolved
ws-nextjs-app/pages/[service]/topics/[id]/[[...variant]].page.tsx
Outdated
Show resolved
Hide resolved
|
Thanks for adding the |
|
Thanks for the updates, looks like this bit can be removed since its repeated above:
|
Sorry I don't think we are wanting to remove this, I don't see any repeats above? |
These lines here should do the same thing: https://github.com/bbc/simorgh/pull/13593/files#diff-081cd4618c7234f3d5377f59f4fc1bb534b5c990337834dce072f575ad796140R45-R47 |
I just seen that and was going to delete my message lol |
amoore108
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for addressing the comments 🙏
Resolves JIRA: https://bbc.atlassian.net/browse/WS-1943
Summary
Created new route in Simorgh to render topic pages in NextJS app
Code changes
Developer Checklist
Testing
Ready-For-Test, Local)Ready-For-Test, Test)Ready-For-Test, Preview)Ready-For-Test, Live)Additional Testing Steps
Useful Links