Skip to content

WS-222: Delete componentTrackingContentType & contentType from e2e assertions #13596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alex-magana merged 6 commits into from
Jan 8, 2026
Merged

WS-222: Delete componentTrackingContentType & contentType from e2e assertions #13596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7bb5f16
Remove unused contentType from click and view event assertions
alex-magana Jan 7, 2026
93bf208
Remove componentTrackingContentType and contentType from component tr…
alex-magana Jan 7, 2026
c83bf63
Delete componentTrackingContentType & contentType from Express app e2es
alex-magana Jan 7, 2026
15ba245
Remove indentation
alex-magana Jan 7, 2026
4c784ae
Triage componentTrackingContentType removal
alex-magana Jan 7, 2026
acdb9f0
Merge branch 'latest' into WS-222-clean-up-contentType
alex-magana Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions cypress/e2e/pages/topicPage/index.cy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ const atiAnalyticsTestSuites = [
siteId: 59,
applicationType: 'responsive',
contentType: 'index-category',
componentTrackingContentType: 'topic-page',
tests: [assertPageView],
},
{
Expand All @@ -98,7 +97,6 @@ const atiAnalyticsTestSuites = [
siteId: 33,
applicationType: 'responsive',
contentType: 'index-category',
componentTrackingContentType: 'topic-page',
tests: [
assertPageView,
assertScrollableNavigationComponentView,
Expand Down
4 changes: 0 additions & 4 deletions cypress/e2e/specialFeatures/atiAnalytics/assertions/articleLiteSiteLink.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ const { ARTICLE_LITE_SITE_LINK } = COMPONENTS;

export const assertArticleLiteSiteLinkComponentView = ({
pageIdentifier,
contentType,
path,
applicationType,
siteId,
Expand All @@ -21,7 +20,6 @@ export const assertArticleLiteSiteLinkComponentView = ({
assertATIComponentViewEvent({
component: ARTICLE_LITE_SITE_LINK,
pageIdentifier,
contentType,
applicationType,
siteId,
});
Expand All @@ -30,7 +28,6 @@ export const assertArticleLiteSiteLinkComponentView = ({

export const assertArticleLiteSiteLinkComponentClick = ({
pageIdentifier,
contentType,
path,
applicationType,
siteId,
Expand All @@ -49,7 +46,6 @@ export const assertArticleLiteSiteLinkComponentClick = ({
assertATIComponentClickEvent({
component: ARTICLE_LITE_SITE_LINK,
pageIdentifier,
contentType,
applicationType,
siteId,
});
Expand Down
4 changes: 0 additions & 4 deletions cypress/e2e/specialFeatures/atiAnalytics/assertions/featuresAnalysis.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ const { FEATURES } = COMPONENTS;

export const assertFeaturesAnalysisComponentView = ({
pageIdentifier,
contentType,
path,
applicationType,
siteId,
Expand All @@ -19,7 +18,6 @@ export const assertFeaturesAnalysisComponentView = ({
assertATIComponentViewEvent({
component: FEATURES,
pageIdentifier,
contentType,
applicationType,
siteId,
});
Expand All @@ -28,7 +26,6 @@ export const assertFeaturesAnalysisComponentView = ({

export const assertFeaturesAnalysisComponentClick = ({
pageIdentifier,
contentType,
path,
applicationType,
siteId,
Expand All @@ -45,7 +42,6 @@ export const assertFeaturesAnalysisComponentClick = ({
assertATIComponentClickEvent({
component: FEATURES,
pageIdentifier,
contentType,
applicationType,
siteId,
});
Expand Down
4 changes: 0 additions & 4 deletions cypress/e2e/specialFeatures/atiAnalytics/assertions/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,6 @@ const assertViewabilityModelViewEvent = ({
export const assertATIComponentViewEvent = ({
component,
pageIdentifier,
contentType,
applicationType,
siteId,
}) => {
Expand All @@ -284,7 +283,6 @@ export const assertATIComponentViewEvent = ({
assertViewabilityModelViewEvent({
component,
pageIdentifier,
contentType,
params,
applicationType,
siteId,
Expand Down Expand Up @@ -320,7 +318,6 @@ const assertViewabilityModelClickEvent = ({

export const assertATIComponentClickEvent = ({
component,
contentType,
pageIdentifier,
applicationType,
siteId,
Expand All @@ -333,7 +330,6 @@ export const assertATIComponentClickEvent = ({
const params = getATIParamsFromURL(url);
assertViewabilityModelClickEvent({
component,
contentType,
pageIdentifier,
params,
applicationType,
Expand Down
4 changes: 0 additions & 4 deletions cypress/e2e/specialFeatures/atiAnalytics/assertions/latestMedia.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ const { LATEST_MEDIA } = COMPONENTS;

export const assertLatestMediaComponentView = ({
pageIdentifier,
contentType,
path,
applicationType,
siteId,
Expand All @@ -19,7 +18,6 @@ export const assertLatestMediaComponentView = ({
assertATIComponentViewEvent({
component: LATEST_MEDIA,
pageIdentifier,
contentType,
applicationType,
siteId,
});
Expand All @@ -28,7 +26,6 @@ export const assertLatestMediaComponentView = ({

export const assertLatestMediaComponentClick = ({
pageIdentifier,
contentType,
path,
applicationType,
siteId,
Expand All @@ -47,7 +44,6 @@ export const assertLatestMediaComponentClick = ({
assertATIComponentClickEvent({
component: LATEST_MEDIA,
pageIdentifier,
contentType,
applicationType,
siteId,
});
Expand Down
3 changes: 0 additions & 3 deletions cypress/e2e/specialFeatures/atiAnalytics/assertions/liteSiteSummary.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ const { LITE_SITE_SUMMARY } = COMPONENTS;
// eslint-disable-next-line import/prefer-default-export
export const assertLiteSiteSummaryComponentToMainSiteClick = ({
pageIdentifier,
contentType,
componentTrackingContentType,
path,
applicationType,
siteId,
Expand All @@ -26,7 +24,6 @@ export const assertLiteSiteSummaryComponentToMainSiteClick = ({
assertATIComponentClickEvent({
component: LITE_SITE_SUMMARY,
pageIdentifier,
contentType: componentTrackingContentType || contentType,
applicationType,
siteId,
});
Expand Down
4 changes: 0 additions & 4 deletions cypress/e2e/specialFeatures/atiAnalytics/assertions/liveMedia.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ const { LIVE_MEDIA } = COMPONENTS;

export const assertLiveMediaComponentView = ({
pageIdentifier,
contentType,
path,
applicationType,
siteId,
Expand All @@ -21,7 +20,6 @@ export const assertLiveMediaComponentView = ({
assertATIComponentViewEvent({
component: LIVE_MEDIA,
pageIdentifier,
contentType,
applicationType,
siteId,
});
Expand All @@ -30,7 +28,6 @@ export const assertLiveMediaComponentView = ({

export const assertLiveMediaComponentClick = ({
pageIdentifier,
contentType,
path,
applicationType,
siteId,
Expand All @@ -48,7 +45,6 @@ export const assertLiveMediaComponentClick = ({
assertATIComponentClickEvent({
component: LIVE_MEDIA,
pageIdentifier,
contentType,
applicationType,
siteId,
});
Expand Down
6 changes: 0 additions & 6 deletions cypress/e2e/specialFeatures/atiAnalytics/assertions/messageBanner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ const { MESSAGE_BANNER } = COMPONENTS;

export const assertMessageBannerComponentView = ({
pageIdentifier,
contentType,
componentTrackingContentType,
path,
applicationType,
siteId,
Expand All @@ -22,7 +20,6 @@ export const assertMessageBannerComponentView = ({
assertATIComponentViewEvent({
component: MESSAGE_BANNER,
pageIdentifier,
contentType: componentTrackingContentType || contentType,
applicationType,
siteId,
});
Expand All @@ -31,8 +28,6 @@ export const assertMessageBannerComponentView = ({

export const assertMessageBannerComponentClick = ({
pageIdentifier,
contentType,
componentTrackingContentType,
path,
applicationType,
siteId,
Expand All @@ -51,7 +46,6 @@ export const assertMessageBannerComponentClick = ({
assertATIComponentClickEvent({
component: MESSAGE_BANNER,
pageIdentifier,
contentType: componentTrackingContentType || contentType,
applicationType,
siteId,
});
Expand Down
4 changes: 0 additions & 4 deletions cypress/e2e/specialFeatures/atiAnalytics/assertions/mostRead.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ const { MOST_READ } = COMPONENTS;

export const assertMostReadComponentView = ({
pageIdentifier,
contentType,
path,
service,
applicationType,
Expand All @@ -27,7 +26,6 @@ export const assertMostReadComponentView = ({
assertATIComponentViewEvent({
component: MOST_READ,
pageIdentifier,
contentType,
applicationType,
siteId,
});
Expand All @@ -36,7 +34,6 @@ export const assertMostReadComponentView = ({

export const assertMostReadComponentClick = ({
pageIdentifier,
contentType,
path,
service,
applicationType,
Expand All @@ -60,7 +57,6 @@ export const assertMostReadComponentClick = ({
assertATIComponentClickEvent({
component: MOST_READ,
pageIdentifier,
contentType,
applicationType,
siteId,
});
Expand Down
12 changes: 0 additions & 12 deletions cypress/e2e/specialFeatures/atiAnalytics/assertions/navigation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ const { SCROLLABLE_NAVIGATION, DROPDOWN_NAVIGATION } = COMPONENTS;

export const assertScrollableNavigationComponentView = ({
pageIdentifier,
contentType,
componentTrackingContentType,
path,
applicationType,
siteId,
Expand All @@ -22,7 +20,6 @@ export const assertScrollableNavigationComponentView = ({
assertATIComponentViewEvent({
component: SCROLLABLE_NAVIGATION,
pageIdentifier,
contentType: componentTrackingContentType || contentType,
applicationType,
siteId,
});
Expand All @@ -31,8 +28,6 @@ export const assertScrollableNavigationComponentView = ({

export const assertScrollableNavigationComponentClick = ({
pageIdentifier,
contentType,
componentTrackingContentType,
path,
applicationType,
siteId,
Expand All @@ -51,7 +46,6 @@ export const assertScrollableNavigationComponentClick = ({
assertATIComponentClickEvent({
component: SCROLLABLE_NAVIGATION,
pageIdentifier,
contentType: componentTrackingContentType || contentType,
applicationType,
siteId,
});
Expand All @@ -61,8 +55,6 @@ export const assertScrollableNavigationComponentClick = ({
// Assertions for nav bar at smaller breakpoints
export const assertDropdownNavigationComponentView = ({
pageIdentifier,
contentType,
componentTrackingContentType,
path,
applicationType,
siteId,
Expand All @@ -77,7 +69,6 @@ export const assertDropdownNavigationComponentView = ({
assertATIComponentViewEvent({
component: DROPDOWN_NAVIGATION,
pageIdentifier,
contentType: componentTrackingContentType || contentType,
applicationType,
siteId,
});
Expand All @@ -86,8 +77,6 @@ export const assertDropdownNavigationComponentView = ({

export const assertDropdownNavigationComponentClick = ({
pageIdentifier,
contentType,
componentTrackingContentType,
path,
applicationType,
siteId,
Expand All @@ -105,7 +94,6 @@ export const assertDropdownNavigationComponentClick = ({
assertATIComponentClickEvent({
component: DROPDOWN_NAVIGATION,
pageIdentifier,
contentType: componentTrackingContentType || contentType,
applicationType,
siteId,
});
Expand Down
4 changes: 0 additions & 4 deletions cypress/e2e/specialFeatures/atiAnalytics/assertions/podcastLinks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ const { PODCAST_LINKS } = COMPONENTS;

export const assertPodcastLinksComponentView = ({
pageIdentifier,
contentType,
path,
applicationType,
siteId,
Expand All @@ -21,7 +20,6 @@ export const assertPodcastLinksComponentView = ({
assertATIComponentViewEvent({
component: PODCAST_LINKS,
pageIdentifier,
contentType,
applicationType,
siteId,
});
Expand All @@ -30,7 +28,6 @@ export const assertPodcastLinksComponentView = ({

export const assertPodcastLinksComponentClick = ({
pageIdentifier,
contentType,
path,
applicationType,
siteId,
Expand All @@ -49,7 +46,6 @@ export const assertPodcastLinksComponentClick = ({
assertATIComponentClickEvent({
component: PODCAST_LINKS,
pageIdentifier,
contentType,
applicationType,
siteId,
});
Expand Down
4 changes: 0 additions & 4 deletions cypress/e2e/specialFeatures/atiAnalytics/assertions/podcastPromo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ const { PODCAST_PROMO } = COMPONENTS;

export const assertPodcastPromoComponentView = ({
pageIdentifier,
contentType,
path,
applicationType,
siteId,
Expand All @@ -21,7 +20,6 @@ export const assertPodcastPromoComponentView = ({
assertATIComponentViewEvent({
component: PODCAST_PROMO,
pageIdentifier,
contentType,
applicationType,
siteId,
});
Expand All @@ -30,7 +28,6 @@ export const assertPodcastPromoComponentView = ({

export const assertPodcastPromoComponentClick = ({
pageIdentifier,
contentType,
path,
applicationType,
siteId,
Expand All @@ -49,7 +46,6 @@ export const assertPodcastPromoComponentClick = ({
assertATIComponentClickEvent({
component: PODCAST_PROMO,
pageIdentifier,
contentType,
applicationType,
siteId,
});
Expand Down
Loading
Loading