WS-2281 Migrate a Few Homepage E2E Tests from Cypress to Playwright and Integrate with CI by MeriemMechri · Pull Request #13670 · bbc/simorgh

MeriemMechri · 2026-02-02T22:01:44Z

Resolves JIRA: WS-2015

Summary

Add Playwright + unified E2E framework dependencies and initial Home Page Playwright spec/helpers.
Introduce a dedicated Playwright GitHub Actions workflow and adjust existing workflows’ install step to authenticate GitHub dependency fetches.
Bump Yarn version/config and update Jest/TS configs to avoid picking up Playwright files in unit test runs.

Code changes

I got into several issues in this upgrade since this project uses yarn, unlike other internal projects that use npm, evenutally - after a LOT of failed attempts - I had to:

I had to bump yarn version from 4.0.9 to 4.13.0 because of this error - the fix for it is to upgrade to >=4.12
To be able to run yarn on CI for a private repo, I did this solution .. I tried setting up npmAuth for yarn but didn't work.

Testing

List the steps required to test this PR.

Useful Links

Coding Standards
Repository use guidelines
Add Links to useful resources related to this PR if applicable.

…right-sample-tests

Copilot

Pull request overview

Copilot reviewed 14 out of 25 changed files in this pull request and generated 12 comments.

Copilot · 2026-04-13T07:02:20Z

+    // these rules seem to be used as the common pattern for looping elemnts in playwright
+    "no-restricted-syntax": ["off", "ForOfStatement"],
+    "no-await-in-loop": "off",
+  },


This .eslintrc file is likely to fail parsing: it’s extensionless (YAML/JSON legacy format), but it contains // comments and trailing commas (e.g. after "no-await-in-loop": "off"). Consider switching to a .eslintrc.js (or valid YAML/JSON without trailing commas) and set the rule values using ESLint’s expected shapes (e.g. no-restricted-syntax: "off").

Suggested change

// these rules seem to be used as the common pattern for looping elemnts in playwright

"no-restricted-syntax": ["off", "ForOfStatement"],

"no-await-in-loop": "off",

},

"no-restricted-syntax": "off",

"no-await-in-loop": "off"

}

Copilot · 2026-04-13T07:02:20Z

+        base.beforeAll(async ({ page }) => {
+          for (const fn of beforeAll) fn();
+          await page.goto(path, { waitUntil: 'domcontentloaded' });
+        });
+
+        base.beforeEach(async () => {
+          for (const fn of beforeEachFns) fn();
+          // Add any Playwright-specific setup here
+        });


The beforeAll / beforeEachFns hooks are invoked without await, and they’re typed as synchronous () => void. If any of these setup functions need to be async (common for Playwright), the current implementation will race. Consider allowing () => void | Promise<void> and awaiting each function inside the Playwright hooks.

…right-sample-tests

MeriemMechri · 2026-04-14T08:15:56Z

@alex-magana , @andrewscfc I am ignoring the copilot comments about runTestsForPage - this file is based on the Cypress helpers we had to make the migration from Cypress to PlayWright easier, and is likely going to change a lot once the actual migration starts. The scope of this PR was mainly to get PlayWright and the unified testing framework running locally and on CI.

…right-sample-tests

remove unused helper for now, and add command to package

…right-sample-tests

Copilot

Pull request overview

Copilot reviewed 13 out of 24 changed files in this pull request and generated 6 comments.

Comments suppressed due to low confidence (1)

.github/workflows/simorgh-unit-tests.yml:48

This workflow now relies on repo secrets (WS_UTF_*) during pull_request runs. For PRs from forks, GitHub Actions does not provide secrets, so yarn install will fail when it tries to fetch the private GitHub dependency. Consider gating the job (or at least the secret-dependent install snippet) to same-repo PRs, similar to how other steps already check github.event.pull_request.head.repo.full_name.

      - name: Install Node Modules
        if: steps.cache.outputs.cache-hit != 'true'
        run: |
          rm -rf node_modules
          git config --global user.name "${{ secrets.WS_UTF_USERNAME }}"
          git config --global user.email "${{ secrets.WS_UTF_EMAIL }}"
          git config --global url.https://${{ secrets.WS_UTF_AUTH }}@github.com/.insteadOf https://github.com/
          ./scripts/installNodeModules.sh

      - name: Build Simorgh - Express App
        run: yarn build

      - name: Build Simorgh - Next.JS App
        working-directory: ./ws-nextjs-app

Copilot · 2026-04-14T16:02:19Z

      - name: Install Node Modules
        if: steps.cache.outputs.cache-hit != 'true'
-        run: ./scripts/installNodeModules.sh
+        run: |
+          rm -rf node_modules
+          git config --global user.name "${{ secrets.WS_UTF_USERNAME }}"
+          git config --global user.email "${{ secrets.WS_UTF_EMAIL }}"
+          git config --global url.https://${{ secrets.WS_UTF_AUTH }}@github.com/.insteadOf https://github.com/
+          ./scripts/installNodeModules.sh


This workflow now relies on repo secrets (WS_UTF_*) during pull_request runs. For PRs from forks, GitHub Actions does not provide secrets, so yarn install will fail when it tries to fetch the private GitHub dependency. Consider gating the job (or the secret-dependent install snippet) to same-repo PRs to avoid failing forked PRs unexpectedly.

Copilot · 2026-04-14T16:02:19Z

      - name: Install Node Modules
        if: steps.cache.outputs.cache-hit != 'true'
-        run: ./scripts/installNodeModules.sh
+        run: |
+          rm -rf node_modules
+          git config --global user.name "${{ secrets.WS_UTF_USERNAME }}"
+          git config --global user.email "${{ secrets.WS_UTF_EMAIL }}"
+          git config --global url.https://${{ secrets.WS_UTF_AUTH }}@github.com/.insteadOf https://github.com/
+          ./scripts/installNodeModules.sh


This workflow now relies on repo secrets (WS_UTF_*) during pull_request runs. For PRs from forks, GitHub Actions does not provide secrets, so yarn install will fail when it tries to fetch the private GitHub dependency. Consider gating the job (or the secret-dependent install snippet) to same-repo PRs to avoid failing forked PRs unexpectedly.

Copilot · 2026-04-14T16:02:19Z

      - name: Install Node Modules
        if: steps.cache.outputs.cache-hit != 'true'
-        run: ./scripts/installNodeModules.sh
+        run: |
+          rm -rf node_modules
+          git config --global user.name "${{ secrets.WS_UTF_USERNAME }}"
+          git config --global user.email "${{ secrets.WS_UTF_EMAIL }}"
+          git config --global url.https://${{ secrets.WS_UTF_AUTH }}@github.com/.insteadOf https://github.com/
+          ./scripts/installNodeModules.sh


This workflow now relies on repo secrets (WS_UTF_*) during pull_request runs. For PRs from forks, GitHub Actions does not provide secrets, so yarn install will fail when it tries to fetch the private GitHub dependency. Consider gating the job (or the secret-dependent install snippet) to same-repo PRs to avoid failing forked PRs unexpectedly.

This comment is valid, it should probably have a broader tech ticket around actions to run for open source forks

…right-sample-tests

andrewscfc · 2026-04-15T08:05:23Z

      - name: Install Node Modules
        if: steps.cache.outputs.cache-hit != 'true'
-        run: ./scripts/installNodeModules.sh
+        run: |
+          rm -rf node_modules
+          git config --global user.name "${{ secrets.WS_UTF_USERNAME }}"
+          git config --global user.email "${{ secrets.WS_UTF_EMAIL }}"
+          git config --global url.https://${{ secrets.WS_UTF_AUTH }}@github.com/.insteadOf https://github.com/
+          ./scripts/installNodeModules.sh


This comment is valid, it should probably have a broader tech ticket around actions to run for open source forks

MeriemMechri added 9 commits February 2, 2026 21:59

test(playwright):start migration with homePage

30ff686

test(playwright):add helpers files

9fb58ff

Merge branch 'latest' of https://github.com/bbc/simorgh into ws-playw…

1fd6733

…right-sample-tests

Merge branch 'latest' of https://github.com/bbc/simorgh into ws-playw…

78179d7

…right-sample-tests

Merge branch 'latest' of https://github.com/bbc/simorgh into ws-playw…

e7b5da6

…right-sample-tests

Merge branch 'latest' of https://github.com/bbc/simorgh into ws-playw…

d874188

…right-sample-tests

Merge branch 'latest' of https://github.com/bbc/simorgh into ws-playw…

935f8e6

…right-sample-tests

Merge branch 'latest' of https://github.com/bbc/simorgh into ws-playw…

6acc7dd

…right-sample-tests

test: print user info in GH action

3a08945

MeriemMechri force-pushed the ws-playwright-sample-tests branch 2 times, most recently from f0b411a to 3a08945 Compare March 24, 2026 11:55

MeriemMechri added 6 commits March 24, 2026 11:58

Merge branch 'latest' into ws-playwright-sample-tests

66510d1

test WS_UTF_AUTH token

40da1ab

test

98daebe

test

eae14d7

test:add curl command

5ead5fa

chore: test token for cloning

33797a2

MeriemMechri force-pushed the ws-playwright-sample-tests branch 3 times, most recently from 510d0f8 to 100939e Compare March 24, 2026 14:37

chore: test token for cloning

c1e217f

MeriemMechri force-pushed the ws-playwright-sample-tests branch from 100939e to c1e217f Compare March 24, 2026 14:47

chore: use yarn 4.12

e23b582

MeriemMechri force-pushed the ws-playwright-sample-tests branch 7 times, most recently from 5050a62 to d7e7319 Compare March 24, 2026 15:19

MeriemMechri added 2 commits April 8, 2026 15:20

Merge branch 'latest' of https://github.com/bbc/simorgh into ws-playw…

e1a7565

…right-sample-tests

Merge branch 'latest' of https://github.com/bbc/simorgh into ws-playw…

e4da992

…right-sample-tests

pvaliani reviewed Apr 9, 2026

View reviewed changes

Comment thread .github/workflows/simorgh-misc-checks.yml Outdated

pvaliani approved these changes Apr 9, 2026

View reviewed changes

MeriemMechri added 5 commits April 9, 2026 12:34

Merge branch 'latest' of https://github.com/bbc/simorgh into ws-playw…

be08253

…right-sample-tests

refactor: fix typos in github actions

ed50721

refactor: update path for playwright report

f80cbc5

Merge branch 'latest' of https://github.com/bbc/simorgh into ws-playw…

c542fcf

…right-sample-tests

Merge branch 'latest' of https://github.com/bbc/simorgh into ws-playw…

382d635

…right-sample-tests

alex-magana reviewed Apr 9, 2026

View reviewed changes

Comment thread ws-nextjs-app/playwright/specs/homePage.spec.ts Outdated

alex-magana reviewed Apr 9, 2026

View reviewed changes

Comment thread ws-nextjs-app/playwright.config.ts

alex-magana reviewed Apr 9, 2026

View reviewed changes

Comment thread ws-nextjs-app/playwright/support/helpers/runUrlValidationTest.ts Outdated

andrewscfc reviewed Apr 9, 2026

View reviewed changes

Comment thread ws-nextjs-app/playwright/specs/homePage.spec.ts Outdated

Comment thread ws-nextjs-app/playwright/support/runTestForPage.playwright.ts Outdated

MeriemMechri added 2 commits April 10, 2026 16:38

Merge branch 'latest' of https://github.com/bbc/simorgh into ws-playw…

28841b7

…right-sample-tests

refactor: per comments review

2d30a86

Copilot AI reviewed Apr 13, 2026

View reviewed changes

MeriemMechri added 2 commits April 13, 2026 11:11

Merge branch 'latest' of https://github.com/bbc/simorgh into ws-playw…

c4a89cb

…right-sample-tests

refactor: remove unused code

0ba9d12

MeriemMechri added 2 commits April 14, 2026 10:14

Merge branch 'latest' of https://github.com/bbc/simorgh into ws-playw…

5b01e60

…right-sample-tests

Merge branch 'latest' of https://github.com/bbc/simorgh into ws-playw…

537c87e

…right-sample-tests

alex-magana reviewed Apr 14, 2026

View reviewed changes

Comment thread package.json

MeriemMechri added 3 commits April 14, 2026 13:42

refactor: code review comments

b13c636

remove unused helper for now, and add command to package

Merge branch 'latest' of https://github.com/bbc/simorgh into ws-playw…

f78ef41

…right-sample-tests

Merge branch 'latest' of https://github.com/bbc/simorgh into ws-playw…

d171ebc

…right-sample-tests

Copilot AI reviewed Apr 14, 2026

View reviewed changes

MeriemMechri added 2 commits April 14, 2026 17:20

Merge branch 'latest' of https://github.com/bbc/simorgh into ws-playw…

9040a06

…right-sample-tests

refactor: copilot code review comments

11fb587

andrewscfc approved these changes Apr 15, 2026

View reviewed changes

amoore108 mentioned this pull request Apr 15, 2026

Revert "WS-2281 Migrate a Few Homepage E2E Tests from Cypress to Play… #13908

Merged

Uh oh!

Conversation

MeriemMechri commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Code changes

Testing

Useful Links

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MeriemMechri commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

andrewscfc Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

andrewscfc Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

MeriemMechri commented Feb 2, 2026 •

edited

Loading

MeriemMechri commented Apr 14, 2026 •

edited

Loading