Don't commit assets #199
Don't commit assets #199
Conversation
|
It's tested this locally, and for me |
|
thanks for testing! I'll re-test with a clean state. |
|
Also if it's not too complex it would be good to test it in travis. Maybe a |
|
good idea! 👍 |
Signed-off-by: Maxim Sukharev <[email protected]>
Signed-off-by: Maxim Sukharev <[email protected]>
Signed-off-by: Maxim Sukharev <[email protected]>
Signed-off-by: Maxim Sukharev <[email protected]>
Signed-off-by: Maxim Sukharev <[email protected]>
Signed-off-by: Maxim Sukharev <[email protected]>
|
| GO_BUILD_ARGS := -ldflags "$(LD_FLAGS)" -tags "$(WITH_STATIC_TAG)" | ||
|
|
||
| # Environment and arguments to use in `go run` calls. | ||
| GO_RUN_ARGS += -tags "$(WITH_STATIC_TAG)" |
There was a problem hiding this comment.
this didn't came from lookout-web
There was a problem hiding this comment.
in lookout-web it looks like this: https://github.com/src-d/lookout/blob/master/Makefile.web#L69
same-same
There was a problem hiding this comment.
kind of same functionality, but subtle different code (ie. GO_RUN_ARGS does not appear in that Makefile.web)
But as I said, not blocker at all, so we can merge as it is.
(I also locally tested, and worked like a charm)
There was a problem hiding this comment.
yeah. Maybe we can actually extract go-handler part & Makefile somewhere and then just re-use in our projects. @carlosms wdyt? Shall I create an issue for that?
There was a problem hiding this comment.
+1
I've been proposing that since years 🎉
There was a problem hiding this comment.
sounds good to me. Let's open that issue :)
There was a problem hiding this comment.
| GO_RUN_ARGS += -tags "$(WITH_STATIC_TAG)" | ||
|
|
||
| GOCMD = go | ||
| GORUN = $(GOCMD) run $(GO_RUN_ARGS) |
|
pretty good idea adding integration tests ! 🎉 |
| // we handle urls on frontend | ||
| r.NoRoute(func(c *gin.Context) { c.File(indexPath) }) | ||
|
|
||
| // TODO(@smacker): add configuration for ServerURL and FooterHTML |
There was a problem hiding this comment.
This is functionality brought from the code c&p from lookout, but we can't use yet in bblfsh web, right?
Should we have an issue for this, to implement it later?
fix #192
Now it works the same as any other apps project.
I also replaced bindata with esc.
static_files_dev.go&static_files.goare 100% copy-paste from lookout-web.Makefile still looks a bit strange but changing it is out of the scope.