Skip to content

Hi! I cleaned up your code for you! #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GunioRobot wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Hi! I cleaned up your code for you! #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion LICENSE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@ FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
IN THE SOFTWARE.
IN THE SOFTWARE.
8 changes: 4 additions & 4 deletions libdtrace.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,7 +501,7 @@ DTraceConsumer::consume(const dtrace_probedata_t *data,

if (!dtc->valid(rec)) {
char errbuf[256];

/*
* If this is a printf(), we'll defer to the bufhandler.
*/
Expand All @@ -512,7 +512,7 @@ DTraceConsumer::consume(const dtrace_probedata_t *data,
"in record for %s:%s:%s:%s\n",
dtc->action(rec, errbuf, sizeof (errbuf)),
pd->dtpd_provider, pd->dtpd_mod,
pd->dtpd_func, pd->dtpd_name);
pd->dtpd_func, pd->dtpd_name);
return (DTRACE_CONSUME_ABORT);
}

Expand Down Expand Up @@ -764,7 +764,7 @@ DTraceConsumer::aggwalk(const dtrace_aggdata_t *agg, void *arg)
Local<Array> *ranges, datum;
int i, j = 0;

ranges = dtc->ranges_quantize(aggdesc->dtagd_varid);
ranges = dtc->ranges_quantize(aggdesc->dtagd_varid);

for (i = 0; i < DTRACE_QUANTIZE_NBUCKETS; i++) {
if (!data[i])
Expand Down Expand Up @@ -888,7 +888,7 @@ DTraceConsumer::Version(const Arguments& args)
}

extern "C" void
init (Handle<Object> target)
init (Handle<Object> target)
{
DTraceConsumer::Initialize(target);
}
2 changes: 1 addition & 1 deletion tests/test-footprint.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,5 +61,5 @@ setInterval(function () {
if (seconds >= end) {
delete dtp;
dtp = undefined;
}
}
}, 10);
2 changes: 1 addition & 1 deletion tests/test-printf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ var libdtrace = require('libdtrace');
var assert = require('assert');

dtp = new libdtrace.Consumer();
dtp.strcompile('BEGIN { printf("{ foo: %d", 123); printf(", bar: %d", 456); }');
dtp.strcompile('BEGIN { printf("{ foo: %d", 123); printf(", bar: %d", 456); }');

dtp.go();

Expand Down
8 changes: 4 additions & 4 deletions tests/test-sched.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@ dtp = new libdtrace.Consumer();

prog =
'sched:::on-cpu\n' +
'{\n' +
'{\n' +
' self->on = timestamp;\n' +
'}\n' +
'\n' +
'sched:::off-cpu\n' +
'/self->on/\n' +
'{\n' +
'{\n' +
' @ = lquantize((timestamp - self->on) / 1000, \n' +
' 0, 10000, 100);\n' +
'}\n' +
Expand All @@ -30,7 +30,7 @@ var start = new Date();
setInterval(function () {

var delta = (new Date()).valueOf() - start.valueOf();

if (delta >= 5000)
process.exit(0);

Expand All @@ -39,7 +39,7 @@ setInterval(function () {

if (data.length >= 50)
return;

for (i = data.length - 1; i >= 0 && i >= data.length - 5; i--)
util.puts(util.inspect(data[i], false, null));
});
Expand Down