Introduce KeyIdentifier class #1752
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanitasvitae
added a commit
to pgpainless/bc-java
that referenced
this pull request
Aug 7, 2024
TODO: Revert once bcgit#1752 is merged
key-ids shall transition to fingerprints
vanitasvitae
force-pushed
the
keyIdentifier
branch
from
3aa6c59 to
0c41c3c
Compare
vanitasvitae
added a commit
to pgpainless/bc-java
that referenced
this pull request
Aug 8, 2024
TODO: Revert once bcgit#1752 is merged
vanitasvitae
added a commit
to pgpainless/bc-java
that referenced
this pull request
Aug 10, 2024
TODO: Revert once bcgit#1752 is merged
vanitasvitae
added a commit
to pgpainless/bc-java
that referenced
this pull request
Sep 10, 2024
TODO: Revert once bcgit#1752 is merged
vanitasvitae
added a commit
to pgpainless/bc-java
that referenced
this pull request
Sep 10, 2024
TODO: Revert once bcgit#1752 is merged
hubot
pushed a commit
that referenced
this pull request
Sep 11, 2024
|
In main as a7930a2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For historic reasons, many places in the OpenPGP API and specification rely on 64-bit key-ids.
However, later versions of the standard migrate to use fingerprints (20 or 32 bytes) to reduce the risk of attacks based on the birthday paradox (key-id collisions).
In this PR I introduce the
KeyIdentifierclass, which can be created from both a key-id or a fingerprint, and which shall be used as a common stand-in for either key-id or fingerprints.This enables a smooth transition from using key-ids to using fingerprints.
TODO:
KeyIdentifierinto existing API to transition away from pure key-ID uses