Add Watermark to OCA Bundle README and update JSON Index generation script#162
Draft
swcurran wants to merge 5 commits intobcgov:mainfrom
Draft
Add Watermark to OCA Bundle README and update JSON Index generation script#162swcurran wants to merge 5 commits intobcgov:mainfrom
swcurran wants to merge 5 commits intobcgov:mainfrom
Conversation
…cript Signed-off-by: Stephen Curran <swcurran@gmail.com>
Signed-off-by: Stephen Curran <swcurran@gmail.com>
Signed-off-by: Stephen Curran <swcurran@gmail.com>
Signed-off-by: Stephen Curran <swcurran@gmail.com>
Contributor
Author
|
@cvarjao has asked that this be considered from a broader perspective -- can we invest more in the process, so that we can keep the watermark in the OCA Bundle while still reducing the source (Excel) files. For example, perhaps we can inject the watermark into the OCA Bundle at Bundle generation time? Putting this on hold for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the README.md file in all of the OCA Bundle folders to add a
Watermarkcolumn to the table of identifiers in the file. Set the value to blank if there is no watermark in the related OCABundles.json file, or set the value to be the English ("en") and French ("fr") values found in the OCABundle.json file.Also updated the script that generates the OCA Bundle index JSON files (
ocabundles.json,ocabundleslist.json) to add the watermarks collected per identifier into the indices.Note that ALL OCA Bundle README files were updated, inlcuding those contributed by others. The intention is that there will NO impact (and this has been tested) on the display of the related credentials.
Next steps:
Commits: