Add City of Vancouver Test Property Rental Business Licence OCA Bundle#166
Merged
swcurran merged 2 commits intobcgov:mainfrom Aug 22, 2025
Merged
Add City of Vancouver Test Property Rental Business Licence OCA Bundle#166swcurran merged 2 commits intobcgov:mainfrom
swcurran merged 2 commits intobcgov:mainfrom
Conversation
Signed-off-by: Stephen Curran <swcurran@gmail.com>
Contributor
Author
|
FYI @krobinsonca . Please coordinate the review with those that are appropriate. Once merged, this should be picked up by the BC Wallet -- and be visible on the https://bcgov.github.io/aries-oca-bundles/ site. The data I was given did not specify the Primary/Secondary fields, so I used the Licence Number and Family Name from the credential. That should be verified -- let me know if changes are needed. Likewise the contacts in the README.md file. |
|
Thanks @swcurran. Some comments:
|
Signed-off-by: Stephen Curran <swcurran@gmail.com>
Contributor
Author
|
PR has been updated per @mathieuglaude 's comments. |
krobinsonca
approved these changes
Aug 22, 2025
Contributor
krobinsonca
left a comment
There was a problem hiding this comment.
Reviewed and approved for DEV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the City of Vancouver as an issuer (parallel to bcgov-digital-trust) and its Rental Property Business Licence VC -- for Testing.
Logos are included in the repo and referenced in the branding overlay.
Likely should check who should be authorized to approve updates to the OCA Bundle -- I've guessed at contacts for now.