Update generate JSON files script to differentiate identifiers by type -- schema and credDef, fix some identifiers and URLs#169
Merged
esune merged 1 commit intobcgov:mainfrom Sep 19, 2025
Conversation
…e -- schema and credDef, fix some identifiers and URLs Signed-off-by: Stephen Curran <swcurran@gmail.com>
Contributor
Author
|
@krobinsonca @esune -- when you get a chance. |
esune
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The script that generates the JSON file used by OCA File has a
typeattribute that was being set toschemafor all identifiers. The script has been updated to search the content of the URL associated with the identifier to determine if it is actually a CLAIM_DEF/CredDef, and if so, sets the type properly to "credDef". The script was been written so that it will (should?) work with did:webvh AnonCreds files, once those are available.In doing this, I found a number of URLs to files that were incorrect:
All of these are now fixed -- as part of this PR.
There are also new copies of the latest JSON files -- but these are not the ones that should be used. The GitHub Pages JSON files are correct. We could .gitignore the ones in the repo, and remove them. But that's another PR.