Skip to content

Conversation

@beNative
Copy link
Owner

Summary

  • enable stricter TypeScript compiler options and add module shims for Vite and better-sqlite3
  • resolve strict null/optional typing issues across renderer components, hooks, and repository services
  • harden preview renderers and database flows while recording the passing typecheck in the consolidation QA log

Testing

  • npx tsc --noEmit

https://chatgpt.com/codex/tasks/task_e_68f71ef0b0448332ac72456ffa19147c

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +144 to +148
const gitHubProviderPrototype = GitHubProvider.prototype as unknown as {
getLatestTagName: (this: GitHubProvider, cancellationToken?: unknown) => Promise<string>;
};
const originalGetLatestTagName = gitHubProviderPrototype.getLatestTagName.bind(GitHubProvider.prototype);
gitHubProviderPrototype.getLatestTagName = async function (this: GitHubProvider, cancellationToken?: unknown) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve GitHubProvider instance when falling back

The override stores originalGetLatestTagName as gitHubProviderPrototype.getLatestTagName.bind(GitHubProvider.prototype). Because the function is already bound to the prototype, the later originalGetLatestTagName.call(this, …) ignores the instance this and executes with this === GitHubProvider.prototype, so this.options and this.httpRequest are undefined. Whenever both GitHub REST calls fail and the fallback is invoked, the updater will now throw before returning a tag name, breaking auto-update checks in offline or error scenarios. Store the unbound method instead so call(this) preserves the instance context.

Useful? React with 👍 / 👎.

@beNative beNative closed this Oct 22, 2025
@beNative beNative deleted the codex/create-docforge-quality-consistency-sweep-2m5tzv branch October 22, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant