fix(csvbase): do not persist auto-detected self.order#161
Merged
blais merged 2 commits intobeancount:masterfrom Mar 19, 2025
Merged
fix(csvbase): do not persist auto-detected self.order#161blais merged 2 commits intobeancount:masterfrom
blais merged 2 commits intobeancount:masterfrom
Conversation
2e0cfe4 to
3ec3599
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today when I batch import two years of statements for a rarely-used account, I find this auto detection of row order might produce incorrect results.
For example, there is only one transaction in January:
... and four transactions in February:
When processing the January file, the code auto-detects the order as
ASCENDINGas there is only one transaction, and for Feburary and any subsequent files, the code no longer tries to detect the order becauseself.orderis already set. But this bank actually usesDESCENDINGorder for their files.This error might be masked if the entries are eventually sorted. But I disabled sorting for some other reason so I hit this edge case.