Get yahoo price series only when price is not None#83
Merged
blais merged 1 commit intobeancount:masterfrom Dec 16, 2023
Merged
Conversation
|
I recently hit an issue that was fixed by this PR. This is a redacted stack trace of my issue. @blais can we merge this PR please? |
Member
|
SGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there is a bank holiday, no pricing data is available. In case of AAPL (https://finance.yahoo.com/quote/AAPL/history?p=AAPL, see 2023-07-04) timeseries returned by an API call simply skips this particular date. However, securities traded in Warsaw Stock Exchange (e. g. PKO.WA, https://finance.yahoo.com/quote/PKO.WA/history?p=PKO.WA, see 2023-11-01), return timeseries with None as a price for a timestamp of a bank holiday. This causes an exception to by thrown.
This PR simply filters out onle these timestamps with non-None price.