Skip to content

frontend: use darker text color on charts#2216

Open
jakobhellermann wants to merge 2 commits intobeancount:mainfrom
jakobhellermann:chart-text-color
Open

frontend: use darker text color on charts#2216
jakobhellermann wants to merge 2 commits intobeancount:mainfrom
jakobhellermann:chart-text-color

Conversation

@jakobhellermann
Copy link

fixes #2215

Dark:
image
image
Light:
image
image

@jakobhellermann jakobhellermann marked this pull request as draft February 8, 2026 22:33
@jakobhellermann
Copy link
Author

as is, this messes up the date texts
image
image

@yagebu
Copy link
Member

yagebu commented Feb 12, 2026

Thanks for opening a PR. I think the fix here needs to be to have different colors for the different texts:

  • the legend is on the background, which is different in dark and light mode - so these texts also need to adjust
  • the chart colors are the same in dark and light, so the text color there should probably stay the same as well

@jakobhellermann
Copy link
Author

Okay I changed the PR to only apply the new text-on-chart color for the icicle and treemap charts, and keep the rest as is.

@jakobhellermann jakobhellermann marked this pull request as ready for review March 15, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bad contrast on trial balance chart/text

2 participants